Skip to content

Conversation

feiskyer
Copy link
Contributor

What does this PR do?

Enhance AKS managed cluster information with comprehensive properties

  • Added detailed AKS managed cluster properties
  • Added networking details (further tools would need them as well)
  • Enhanced unit tests and live tests to validate new properties

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@feiskyer feiskyer requested review from gossion and a team as code owners September 18, 2025 04:19
@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 04:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances AKS managed cluster and nodepool information by adding comprehensive properties to provide richer details about Azure Kubernetes Service resources. The changes expand the data models to include networking details, identity profiles, upgrade settings, and other advanced configuration properties that would be useful for downstream tools.

  • Added detailed cluster properties including network profiles, Windows profiles, identity profiles, and addon configurations
  • Extended nodepool models with networking, security, GPU, and upgrade settings
  • Enhanced unit and live tests to validate the new comprehensive properties

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
AksService.cs Core service logic updates to populate enriched cluster and nodepool properties from Azure API responses
Cluster.cs Extended cluster model with comprehensive properties like network profiles, identity details, and addon configurations
NodePool.cs Added extensive nodepool properties for networking, security, GPU settings, and upgrade configurations
ClusterNetworkProfile.cs New model for detailed cluster networking configuration including load balancer profiles
ClusterProfiles.cs New model classes for various cluster profile types (security, storage, metrics, etc.)
WindowsProfile.cs New model for Windows-specific cluster configuration
ServicePrincipalProfile.cs New model for service principal authentication details
ResourceIdentity.cs New models for managed identity references and resource identity information
OidcIssuerProfile.cs New model for OIDC issuer configuration
AksJsonContext.cs Updated JSON serialization context to include all new model types
Various test files Enhanced unit and live tests to validate new properties and ensure serialization works correctly
CHANGELOG.md Updated changelog to document the enhancement

@feiskyer feiskyer enabled auto-merge (squash) September 18, 2025 07:41
niu-peng pushed a commit to niu-peng/mcp that referenced this pull request Sep 18, 2025
@joshfree joshfree added this to the 2025-09 milestone Sep 19, 2025
@joshfree joshfree added the server-Azure.Mcp Azure.Mcp.Server label Sep 19, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 19, 2025
@feiskyer
Copy link
Contributor Author

@joshfree what does it mean by assigning my PR to myself?

@feiskyer feiskyer merged commit 8850f65 into microsoft:main Sep 22, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 22, 2025
@feiskyer feiskyer deleted the aks-cluster-info branch September 22, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server-Azure.Mcp Azure.Mcp.Server
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants