-
Notifications
You must be signed in to change notification settings - Fork 196
Enhance AKS managed cluster information with comprehensive properties #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances AKS managed cluster and nodepool information by adding comprehensive properties to provide richer details about Azure Kubernetes Service resources. The changes expand the data models to include networking details, identity profiles, upgrade settings, and other advanced configuration properties that would be useful for downstream tools.
- Added detailed cluster properties including network profiles, Windows profiles, identity profiles, and addon configurations
- Extended nodepool models with networking, security, GPU, and upgrade settings
- Enhanced unit and live tests to validate the new comprehensive properties
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
AksService.cs | Core service logic updates to populate enriched cluster and nodepool properties from Azure API responses |
Cluster.cs | Extended cluster model with comprehensive properties like network profiles, identity details, and addon configurations |
NodePool.cs | Added extensive nodepool properties for networking, security, GPU settings, and upgrade configurations |
ClusterNetworkProfile.cs | New model for detailed cluster networking configuration including load balancer profiles |
ClusterProfiles.cs | New model classes for various cluster profile types (security, storage, metrics, etc.) |
WindowsProfile.cs | New model for Windows-specific cluster configuration |
ServicePrincipalProfile.cs | New model for service principal authentication details |
ResourceIdentity.cs | New models for managed identity references and resource identity information |
OidcIssuerProfile.cs | New model for OIDC issuer configuration |
AksJsonContext.cs | Updated JSON serialization context to include all new model types |
Various test files | Enhanced unit and live tests to validate new properties and ensure serialization works correctly |
CHANGELOG.md | Updated changelog to document the enhancement |
b7bf159
to
506db1c
Compare
506db1c
to
7e0145e
Compare
7e0145e
to
bdfaccc
Compare
@joshfree what does it mean by assigning my PR to myself? |
What does this PR do?
Enhance AKS managed cluster information with comprehensive properties
GitHub issue number?
[Link to the GitHub issue this PR addresses]
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.md
and/orservers/Fabric.Mcp.Server/CHANGELOG.md
for product changes (features, bug fixes, UI/UX, updated dependencies
)servers/Azure.Mcp.Server/README.md
and/orservers/Fabric.Mcp.Server/README.md
documentation/docs/azmcp-commands.md
and/or/docs/fabric-commands.md
ToolDescriptionEvaluator
and obtained a score of0.4
or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.md
crypto mining, spam, data exfiltration, etc.
)/azp run mcp - pullrequest - live
to run Live Test Pipeline