Add azmcp sql server list command and unit tests
#503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericshape
requested review from
joshfree,
jongio,
vukelich,
xiangyan99,
JonathanCrd,
sandeep-sen and
alzimmermsft
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new command azmcp sql server list that lists Azure SQL servers within a resource group, including comprehensive unit tests and documentation updates.
Key changes:
- Implements a new list command for SQL servers with proper input validation and error handling
- Adds comprehensive unit test coverage including success scenarios, error cases, and edge conditions
- Updates documentation and command registration to include the new functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ServerListCommandTests.cs | Comprehensive unit tests covering validation, success scenarios, error handling, and edge cases |
| SqlSetup.cs | Registers the new ServerListCommand in the command structure |
| SqlService.cs | Implements ListServersAsync method with proper error handling and resource group validation |
| ISqlService.cs | Adds interface definition for the ListServersAsync method |
| ServerListOptions.cs | Defines options class extending SubscriptionOptions for the list command |
| SqlJsonContext.cs | Adds JSON serialization support for ServerListResult |
| ServerListCommand.cs | Main command implementation with validation, execution logic, and error handling |
| e2eTestPrompts.md | Adds test prompts for the new list command functionality |
| azmcp-commands.md | Documents the new command usage and syntax |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
achyuth-ms
approved these changes
Sep 19, 2025
xiangyan99
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
azmcp sql server listcommand and unit testsGitHub issue number?
#126
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline