Skip to content

Commit

Permalink
match comment formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
VivianNK committed Sep 28, 2023
1 parent 8b84ee2 commit bc2c81a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ class GetConfigKnobOverrideFromVariableStorageTest : public Test
UINT64 VariableData;
UINT64 ConfigKnobData;

//
// Redefining the Test class's SetUp function for test fixtures.
//
void
SetUp (
) override
Expand All @@ -55,10 +53,8 @@ class GetConfigKnobOverrideFromVariableStorageTest : public Test
// variable storage. Then, set the profile default value.
//
TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageSmallBufferFailure) {
//
// expect the first GetVariable call to get size
// expect the second call to return an EFI_DEVICE_ERROR
//
// Expect the first GetVariable call to set the correct size
// Expect the second call to return an EFI_DEVICE_ERROR
EXPECT_CALL (
RtServicesMock,
gRT_GetVariable (
Expand Down Expand Up @@ -90,9 +86,7 @@ TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageSmallBuffer
// variable storage. Then, create cached policy.
//
TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageSuccess) {
//
// Expect the first GetVariable call to get size
//
EXPECT_CALL (
RtServicesMock,
gRT_GetVariable
Expand All @@ -104,10 +98,8 @@ TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageSuccess) {
)
);

//
// Expect the second getVariable call to update data
// NOTE: in this case, could also simply do another .WillOnce call. BUt wanted to show a little variety
//
// NOTE: in this case, could also simply do another .WillOnce call. But, wanted to show a little variety
EXPECT_CALL (
RtServicesMock,
gRT_GetVariable (
Expand Down Expand Up @@ -137,9 +129,7 @@ TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageSuccess) {
// variable storage. Then, set the profile default value.
//
TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageNotFoundFailure) {
//
// Expect the first GetVariable call to get size to fail
//
EXPECT_CALL (
RtServicesMock,
gRT_GetVariable
Expand All @@ -159,9 +149,7 @@ TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageNotFoundFai
variable storage. Fail to match variable size with profile default size. Then, set the profile default value.
*/
TEST_F (GetConfigKnobOverrideFromVariableStorageTest, VariableStorageSizeFailure) {
//
// Expect the first GetVariable call to get (non-matching) size
//
EXPECT_CALL (
RtServicesMock,
gRT_GetVariable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,7 @@ TEST_F (GetConfigKnobOverrideFromVariableStorageTest, InvalidParamFailure) {
// Then, set the profile default value.
//
TEST_F (GetConfigKnobOverrideFromVariableStorageTest, PpiNotFoundFailure) {
//
// Expect the locate PPI call to fail
//
EXPECT_CALL (
PeiServicesMock,
PeiServicesLocatePpi
Expand Down

0 comments on commit bc2c81a

Please sign in to comment.