Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupDataPkg: Fix GCC failure in KnobService.py #251

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

makubacki
Copy link
Member

Preface

  • Makes CachedPolicy type consistent in generated file.

  • Removes unused CachedPolicyInitialize variable.

  • Impacts functionality?

    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?

    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?

    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?

    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?

    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • Local and CI build (mu_tiano_platforms integration build)

Integration Instructions

N/A

- Makes CachedPolicy type consistent in generated file.
- Removes unused CachedPolicyInitialize variable.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki added the type:bug Something isn't working label Sep 25, 2023
@makubacki makubacki self-assigned this Sep 25, 2023
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Sep 25, 2023
@kuqin12 kuqin12 requested a review from apop5 September 25, 2023 13:57
@codecov-commenter
Copy link

Codecov Report

Merging #251 (b0ae470) into main (e758130) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head b0ae470 differs from pull request most recent head 153e9a2. Consider uploading reports for the commit 153e9a2 to get more accurate results

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   27.57%   27.58%   +0.01%     
==========================================
  Files          16       16              
  Lines        4522     4520       -2     
==========================================
  Hits         1247     1247              
+ Misses       3275     3273       -2     
Flag Coverage Δ
Linux 27.58% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
SetupDataPkg/Tools/KnobService.py 0.00% <0.00%> (ø)

@makubacki makubacki enabled auto-merge (squash) September 25, 2023 14:41
@makubacki makubacki merged commit 0e8b98c into microsoft:main Sep 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants