-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the default in switch implementation to prevent gcc build error #263
Merged
kuqin12
merged 1 commit into
microsoft:main
from
MarcChen46:user/marcchen/fix_gcc_switch_warning
Oct 13, 2023
Merged
Add the default in switch implementation to prevent gcc build error #263
kuqin12
merged 1 commit into
microsoft:main
from
MarcChen46:user/marcchen/fix_gcc_switch_warning
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
Pull requests that update Python code
impact:non-functional
Does not have a functional impact
labels
Oct 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 27.40% 27.39% -0.02%
==========================================
Files 16 16
Lines 4550 4552 +2
==========================================
Hits 1247 1247
- Misses 3303 3305 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
makubacki
approved these changes
Oct 13, 2023
apop5
approved these changes
Oct 13, 2023
kuqin12
approved these changes
Oct 13, 2023
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Oct 21, 2023
Introduces 6 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/392d2133f236e4c226e57b26692b0d4d558cdff7">392d21</a> pip: bump edk2-pytool-library from 0.18.2 to 0.19.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/261">#261</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/1f6d765aadf55eb6ee4cff3b2e7508fd77a397ba">1f6d76</a> pip: bump edk2-pytool-extensions from 0.24.1 to 0.25.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/262">#262</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/04e6f1824344cc4667caf9c7a9f02305eec879f9">04e6f1</a> Repo File Sync: Update to Mu DevOps v7.0.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/260">#260</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/d4024776261b4d288094c246ec7916ac8287d04f">d40247</a> Add the default in switch implementation to prevent gcc build error (<a href="https://github.com/microsoft/mu_feature_config/pull/263">#263</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c91a9f32bd51b5cb19ccaf0c175f9ab44e1cb781">c91a9f</a> Repo File Sync: Update to Mu DevOps 7.0.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/264">#264</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/decdc3afb084a2389a2bc0122a64addcd3eee8dc">decdc3</a> pip: bump edk2-pytool-library from 0.19.0 to 0.19.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/265">#265</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
language:python
Pull requests that update Python code
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the KnobService.py generate the ConfigDataGenerated.h, it generated the ValidateEnumValueXXXX function that has a switch implementation, but it missed the default: in the switch implementation that cause gcc build failed with [-Werror=switch] error.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Verified the build that include ConfigDataGenerated.h by gcc compile
Integration Instructions
N/A