Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xml_file args from WriteConfVarListToUefiVars.py #420

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

kanechen66
Copy link
Contributor

Description

There is an unnecessary argument -x in the WriteConfVarListToUefiVars.py script in PR #413

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

python WriteConfVarListToUefiVars.py -l test.vl and it doesn't require -x arg

Integration Instructions

N/A

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Nov 8, 2024
@kanechen66
Copy link
Contributor Author

@os-d @apop5
hi Oliver and Aaron
Sorry there was an xml_file (-x) added in WriteConfVarListToUefiVars.py in PR#413
pls help to review this fix
thanks.

@os-d os-d requested a review from apop5 November 8, 2024 18:34
@apop5 apop5 merged commit d342939 into microsoft:main Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants