-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MmSupervisorPkg: Integrate UefiCpuLib breaking change #164
Merged
makubacki
merged 1 commit into
microsoft:main
from
makubacki:integrae_ueficpulib_breaking_change
Aug 30, 2023
Merged
MmSupervisorPkg: Integrate UefiCpuLib breaking change #164
makubacki
merged 1 commit into
microsoft:main
from
makubacki:integrae_ueficpulib_breaking_change
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the repo for a change that merged UefiCpuLib with CpuLib. CpuLib will be removed entirely soon so all references are updated to CpuLib. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
added
the
semver:patch
Pull requests that should increment the release patch version
label
Aug 30, 2023
github-actions
bot
added
the
impact:non-functional
Does not have a functional impact
label
Aug 30, 2023
os-d
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a note that your PR description says CpuLib will be removed, but from the changes, looks like UefiCpuLib will be removed.
Thanks. Updated. |
kenlautner
approved these changes
Aug 30, 2023
5 tasks
kenlautner
pushed a commit
to kenlautner/mu_feature_mm_supv
that referenced
this pull request
Aug 30, 2023
## Description Updates the repo for a change that merged UefiCpuLib with CpuLib. UefiCpuLib will be removed entirely soon so all references are updated to CpuLib. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested - MmSupervisorPkg CI build - Feature integration build (in QemuQ35Pkg) ## Integration Instructions N/A Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
added a commit
to microsoft/mu_tiano_platforms
that referenced
this pull request
Aug 30, 2023
## Description Updates the repo for a change that merged UefiCpuLib with CpuLib. UefiCpuLib will be removed entirely soon so all references are updated to CpuLib. Includes the following submodule updates: - `MU_BASECORE` to `v2023020005.0.1` - `Common/MU` to `v2023020001.4.1` - `Common/MU_TIANO` to `v2023020001.4.1` - `Features/MM_SUPV` to `v8.1.5` --- - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested - CI package build (via PR checks) ## Integration Instructions N/A --- Associated Changes in Submodules - microsoft/mu_feature_mm_supv#164 - microsoft/mu_plus#304 - microsoft/mu_tiano_plus#174 Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
semver:patch
Pull requests that should increment the release patch version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the repo for a change that merged UefiCpuLib with CpuLib.
UefiCpuLib will be removed entirely soon so all references are updated to CpuLib.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Integration Instructions
N/A