Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update override hash on PiSmmCore #349

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Oct 1, 2024

Description

Fixing an override hash failure from PiSmmCore:
microsoft/mu_basecore@36f763d

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This change was tested on Q35.

Integration Instructions

N/A

@kuqin12 kuqin12 enabled auto-merge (squash) October 1, 2024 17:03
@github-actions github-actions bot added impact:security Has a security impact impact:breaking-change Requires integration attention labels Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.50%. Comparing base (4003768) to head (86c764c).

Files with missing lines Patch % Lines
MmSupervisorPkg/Core/Handler/Mmi.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #349      +/-   ##
========================================
- Coverage   0.50%   0.50%   -0.01%     
========================================
  Files        143     143              
  Lines      20942   20943       +1     
  Branches      60      60              
========================================
  Hits         105     105              
- Misses     20832   20833       +1     
  Partials       5       5              
Flag Coverage Δ
MmSupervisorPkg 0.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5
Copy link
Contributor

apop5 commented Oct 1, 2024

@kuqin12
Can you reference the mu_basecore commit that this is bringing up to date with?

@kuqin12 kuqin12 merged commit eec362c into microsoft:main Oct 1, 2024
8 checks passed
@kuqin12 kuqin12 deleted the fix_override branch October 1, 2024 18:27
kenlautner pushed a commit to kenlautner/mu_feature_mm_supv that referenced this pull request Oct 24, 2024
## Description

Fixing an override hash failure from PiSmmCore

For details on how to complete these options and their meaning refer to
[CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md).

- [x] Impacts functionality?
- [x] Impacts security?
- [x] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

This change was tested on Q35.

## Integration Instructions

N/A
kenlautner pushed a commit to kenlautner/mu_feature_mm_supv that referenced this pull request Oct 26, 2024
## Description

Fixing an override hash failure from PiSmmCore

For details on how to complete these options and their meaning refer to
[CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md).

- [x] Impacts functionality?
- [x] Impacts security?
- [x] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

This change was tested on Q35.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:breaking-change Requires integration attention impact:security Has a security impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants