Integrate PEI RNG Shared Crypto #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
the
semver:patch
github-actions
bot
added
the
impact:non-functional
apop5
approved these changes
Aug 2, 2024
|
About to push the SBSA changes, just verifying them locally. |
kenlautner
approved these changes
Aug 2, 2024
makubacki
force-pushed
the
shared_crypto_peirng
branch
2 times, most recently
from
0e9a994
to
9cc211a
Compare
Produces a RNG PPI that is used by shared crypto to abstract platform RNG support. - Updates Mu Basecore to v2023110011.0.0 - Updates Mu Tiano Plus to v2023110001.1.0 - Updates Mu MM Supervisor to v12.0.1 (for overrides) - Updates pytools for compat with Mu Basecore Rust plugin Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
shared_crypto_peirng
branch
from
9cc211a
to
4e8c28b
Compare
This was referenced Aug 3, 2024
|
Its the unit tests from network pkg. microsoft/mu_basecore#891 exposed problems with the linking of unit tests, and this is appearing in the platform based unit tests. The following two files need updated (I can't push them to your branch on your fork, so I put them on mine) With these changes, it should be able to pass the codecoverage tasks. |
The host unit test need changes to the library instances linked to compile and pass. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
shared_crypto_peirng
branch
from
3de44af
to
bbf41de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Produces an RNG PPI that is used by shared crypto to abstract platform RNG support.
Updates Mu Basecore to v2023110010.0.1
Updates Mu Tiano Plus to v2023110001.1.0
Updates Mu MM Supervisor to v12.0.1 (for overrides)
Updates pytools for compat with Mu Basecore Rust plugin
Impacts functionality?
Impacts security?
Breaking change?
Includes tests?
Includes documentation?
How This Was Tested
Integration Instructions