Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cspell 5.20.0 and apply fixes to all relevant files #308

Merged

Conversation

kenlautner
Copy link
Contributor

@kenlautner kenlautner commented Jul 24, 2024

Description

This PR pulls all the cspell commits from release/202311 and combines them into one commit with all the changes. Many of these are minor and inconsequential.

Commits for reference


820b09b : Require cpsell 5.20.0


3ef1a32 : Corrects spelling error in unit test


  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested with CI

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jul 24, 2024
@kenlautner kenlautner force-pushed the personal/klautner/spellcheck branch 4 times, most recently from 2b15b60 to 54e4b56 Compare July 24, 2024 18:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@96bca8b). Learn more about missing BASE report.

Files Patch % Lines
SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c 0.00% 8 Missing ⚠️
SecurityPkg/Library/Tpm2CommandLib/Tpm2Hierarchy.c 0.00% 2 Missing ⚠️
SecurityPkg/Library/Tpm2CommandLib/Tpm2Integrity.c 0.00% 2 Missing ⚠️
SecurityPkg/Library/Tpm2CommandLib/Tpm2Sequences.c 0.00% 2 Missing ⚠️
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c 0.00% 2 Missing ⚠️
...ticated/SecureBootConfigDxe/SecureBootConfigImpl.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202405    #308   +/-   ##
================================================
  Coverage                  ?   1.00%           
================================================
  Files                     ?     147           
  Lines                     ?   34795           
  Branches                  ?     167           
================================================
  Hits                      ?     350           
  Misses                    ?   34445           
  Partials                  ?       0           
Flag Coverage Δ
SecurityPkg 1.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenlautner kenlautner force-pushed the personal/klautner/spellcheck branch from 54e4b56 to e47ed9b Compare July 24, 2024 18:32
@makubacki
Copy link
Member

It is debatable on whether these should have MU_CHANGE tags. I'm personally okay for them not to since git blame should be sufficient for typos.

Update cspell to 5.20.0 and make appropriate spelling changes to ensure CI passes.
@kenlautner kenlautner force-pushed the personal/klautner/spellcheck branch from e47ed9b to 9dd74e2 Compare July 25, 2024 00:40
@kenlautner kenlautner merged commit d41d3eb into microsoft:release/202405 Jul 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants