[CoreML MLProgram] Support Float16 (1/N) #22068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wejoncy
force-pushed
the
jicwen/coreml_fp16
branch
from
e134133
to
305e9ab
Compare
skottmckay
reviewed
Sep 12, 2024
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
wejoncy
force-pushed
the
jicwen/coreml_fp16
branch
from
305e9ab
to
3944fd6
Compare
wejoncy
force-pushed
the
jicwen/coreml_fp16
branch
from
957c4d9
to
4f935e7
Compare
skottmckay
reviewed
Sep 19, 2024
skottmckay
reviewed
Sep 19, 2024
skottmckay
reviewed
Sep 24, 2024
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/builder_utils.h
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/gemm_op_builder.cc
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
…r.cc Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
wejoncy
force-pushed
the
jicwen/coreml_fp16
branch
from
47de692
to
fe3a3a3
Compare
skottmckay
reviewed
Sep 27, 2024
onnxruntime/core/providers/coreml/builders/impl/binary_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Sep 30, 2024
Co-authored-by: Scott McKay <skottmckay@gmail.com>
wejoncy
force-pushed
the
jicwen/coreml_fp16
branch
from
5cb4046
to
6d709d0
Compare
skottmckay
reviewed
Sep 30, 2024
onnxruntime/core/providers/coreml/builders/impl/slice_op_builder.cc
Outdated
Show resolved
Hide resolved
skottmckay
approved these changes
Sep 30, 2024
tianleiwu
pushed a commit
that referenced
this pull request
Oct 11, 2024
### Description ROCm CI fails since adding test for BFloat16, Sqrt op (introduced in #22068).
guschmue
pushed a commit
that referenced
this pull request
Oct 18, 2024
### Description ROCm CI fails since adding test for BFloat16, Sqrt op (introduced in #22068).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Float16 for CoreML MLProgram EP.
Operations:
"Add", "Mul", "Sub", "Div", "Pow", "Sqrt", "Reciprocal",
"Sigmoid", "Tanh", "Relu", "LeakyRelu", "Concat", "GridSample", "GlobalAveragePool",
"Clip", "DepthToSpace", "Resize", "Slice", "Conv",
"ConvTranspose", "GlobalMaxPool", "Gemm", "MatMul",
"AveragePool", "MaxPool", "Reshape", "Split", "Transpose"
Motivation and Context