[WebNN EP] Fix issues of GRU operator #22123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honry
reviewed
Sep 19, 2024
onnxruntime/core/providers/webnn/builders/impl/gru_op_builder.cc
Outdated
Show resolved
Hide resolved
| bool has_Y_h = output_defs.size() > 1 && output_defs[1]->Exists(); | ||
|
|
||
| if (has_Y && !has_Y_h && GetType(*output_defs[0], Y_type, logger)) { | ||
| return IsDataTypeSupportedByOp(op_type, Y_type, wnn_limits, "outputs", "Y", logger); |
There was a problem hiding this comment.
It may return early if this returns True.
There was a problem hiding this comment.
Gru has two outputs (Y, Y_h). The if statement here enumerates all the cases. If the first if here returns True, this is expected. WDYT?
There was a problem hiding this comment.
OK, but this would introduce duplicates GetType for a single output.
How about just one by one check the outputs, and finally check if has both outputs, they should have same type.
|
@fdwr PTAL, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the spelling of the key value of the GRU operator in the map in the
GetSupportedNodesfunction (Gru -> GRU) and removes the data type check for the fifth input (sequence_lens) of the GRU operator.PTAL, thanks!