feat: make TimeoutError extend builtins.TimeoutError#2297
Merged
mxschmitt merged 3 commits intomicrosoft:mainfrom Feb 14, 2024
Merged
feat: make TimeoutError extend builtins.TimeoutError#2297mxschmitt merged 3 commits intomicrosoft:mainfrom
TimeoutError extend builtins.TimeoutError#2297mxschmitt merged 3 commits intomicrosoft:mainfrom
Conversation
TimeoutError extends builtins.TimeoutErrorTimeoutError extend builtins.TimeoutError
Contributor
Author
@microsoft-github-policy-service agree |
Contributor
|
Thank you for your contribution, lets add a test for it? e.g. a small one after here. |
Contributor
Author
|
Good idea! Thank you for the feedback. |
mxschmitt
added a commit
that referenced
this pull request
Feb 20, 2024
…)" This reverts commit 8cd06e5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #1495.
Note, depending on the Python implementation
__builtins__references either the modulebuiltinsor the dictionarybuiltins.__dict__. (Ref). Therefore, I am importingTimeoutErrorasTimeOutErrorBuiltinfrombuiltinsto account for this implementation detail.Additionally, I modified
.gitignoreto ignore Pipenv artifacts.