fix(client-certificates): don't use proxy when using BrowserContext.request #31898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jul 29, 2024
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Max Schmitt <max@schmitt.mx>
This comment has been minimized.
This comment has been minimized.
mxschmitt
added a commit
that referenced
this pull request
Jul 29, 2024
…sing BrowserContext.request
Test results for "tests 1"29212 passed, 694 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: When using
context.requestthefetch()call should still use the native TLS options rather than going the proxy route. Before this patch, it used thedefaultOptionswhich contain the socksProxy in theproxyoptions and it re-used this. this emitted a warning when visiting127.0.0.1, probably due to an upstream bug:Probably a regression of TooTallNate/proxy-agents#308.
So based on this it seems fine to ignore the given proxy settings in fetch, if clientCertificates are given. (We would error before when creating the browser context that both is not supported.)
The test changes are needed in order to trigger this warning, which does not get emitted anymore.