Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve glob to regex in local utils for language ports #35136

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Mar 11, 2025

No description provided.

This comment has been minimized.

@pavelfeldman
Copy link
Member

Why not implement everything that accepts strings on the server-side?

@yury-s yury-s changed the title chore: resolve glob to regex in local utils chore: resolve glob to regex in local utils for language ports Mar 11, 2025

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38713 passed, 807 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants