chore: prepare to move recorder app to the client side #36973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgozman
commented
Aug 9, 2025
dgozman
commented
- Move codegen to isomorphic, generate code on the client side for the recorder api.
- Move deviceDescriptors to isomorphic, as these are used by codegen.
- Remove ProgrammaticRecorderApp as it does not do anything anymore.
- Move actionUpdated logic to the recorder core.
Test results for "tests 1"6 failed 43 flaky46600 passed, 805 skipped Merge workflow run. |
pavelfeldman
approved these changes
Aug 9, 2025
| }; | ||
| const languageGenerator = languages.find(l => l.id === params.language) ?? languages.find(l => l.id === 'playwright-test')!; | ||
|
|
||
| this._channel.on('recorderEvent', ({ event, data, page }) => { |
There was a problem hiding this comment.
How is enable/disable/enable scenario supported?
There was a problem hiding this comment.
Good point, updated.
|
|
||
| static async show(context: BrowserContext, params: channels.BrowserContextEnableRecorderParams) { | ||
| if (process.env.PW_CODEGEN_NO_INSPECTOR) | ||
| if (process.env.PW_CODEGEN_NO_INSPECTOR || params.recorderMode === 'api') |
There was a problem hiding this comment.
recorderMode === 'api' should not get here?
There was a problem hiding this comment.
It does not. I guess I can replace the check with the comment, that would be better.
| if (debugMode() === 'inspector') | ||
| await RecorderApp.show(this, { pauseOnNextStatement: true }); | ||
|
|
||
| // When paused, show inspector. |
There was a problem hiding this comment.
This was dead code. We are initializing the browser context, cannot be already paused here.
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { CSharpLanguageGenerator } from './csharp'; |
There was a problem hiding this comment.
Any reason move is not detected?
There was a problem hiding this comment.
I guess adding types to this small file pushed it over the "changed" threshold.
dgozman
force-pushed
the
chore-recorder-partially-to-client
branch
from
12df65c to
f8ce4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.