Skip to content

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 15, 2025

This one takes care of insets/infobars/etc on all platforms.

Introduced to CPD in Chromium 140.

#37273

This comment has been minimized.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the tests are unhappy :-(

This comment has been minimized.

@dgozman dgozman added the CQ1 label Sep 18, 2025

This comment has been minimized.

This comment has been minimized.

@dgozman
Copy link
Contributor Author

dgozman commented Sep 18, 2025

Hmm... This fails on mac with infobars.

This one takes care of instes/infobars/etc on all platforms.
@dgozman dgozman force-pushed the chore-cr-set-content-size branch from 877ee15 to bb0497a Compare September 19, 2025 10:37
@dgozman dgozman added CQ1 and removed CQ1 labels Sep 19, 2025
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:204 › should not preserve selection across test runs @macos-latest-node18-1

1 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`

46903 passed, 821 skipped


Merge workflow run.

Copy link
Contributor

Test results for "tests others"

2 fatal errors, not part of any test

1 interrupted ⚠️ [electron-page] › page/page-keyboard.spec.ts:394 › should work after a cross origin navigation `@electron-macos-latest`

21611 passed, 474 skipped, 851 did not run


Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
34 failed
❌ [chromium-library] › library/headful.spec.ts:30 › should close browser with beforeunload page @channel-chromium-macos-latest
❌ [chromium-library] › library/headful.spec.ts:69 › should click when viewport size is larger than screen @channel-chromium-macos-latest
❌ [chromium-library] › library/headful.spec.ts:84 › should dispatch click events to oversized viewports @channel-chromium-macos-latest
❌ [chromium-library] › library/headful.spec.ts:213 › Page.bringToFront should work @channel-chromium-macos-latest
❌ [chromium-library] › library/headful.spec.ts:252 › should click bottom row w/ infobar in OOPIF @channel-chromium-macos-latest
❌ [chromium-library] › library/headful.spec.ts:30 › should close browser with beforeunload page @chrome-macos-latest
❌ [chromium-library] › library/headful.spec.ts:69 › should click when viewport size is larger than screen @chrome-macos-latest
❌ [chromium-library] › library/headful.spec.ts:84 › should dispatch click events to oversized viewports @chrome-macos-latest
❌ [chromium-library] › library/headful.spec.ts:213 › Page.bringToFront should work @chrome-macos-latest
❌ [chromium-library] › library/headful.spec.ts:252 › should click bottom row w/ infobar in OOPIF @chrome-macos-latest
❌ [chromium-library] › library/headful.spec.ts:30 › should close browser with beforeunload page @msedge-beta-macos-latest
❌ [chromium-library] › library/headful.spec.ts:69 › should click when viewport size is larger than screen @msedge-beta-macos-latest
❌ [chromium-library] › library/headful.spec.ts:84 › should dispatch click events to oversized viewports @msedge-beta-macos-latest
❌ [chromium-library] › library/headful.spec.ts:213 › Page.bringToFront should work @msedge-beta-macos-latest
❌ [chromium-library] › library/headful.spec.ts:252 › should click bottom row w/ infobar in OOPIF @msedge-beta-macos-latest
❌ [chromium-library] › library/headful.spec.ts:30 › should close browser with beforeunload page @msedge-dev-macos-latest
❌ [chromium-library] › library/headful.spec.ts:69 › should click when viewport size is larger than screen @msedge-dev-macos-latest
❌ [chromium-library] › library/headful.spec.ts:84 › should dispatch click events to oversized viewports @msedge-dev-macos-latest
❌ [chromium-library] › library/headful.spec.ts:213 › Page.bringToFront should work @msedge-dev-macos-latest
❌ [chromium-library] › library/headful.spec.ts:252 › should click bottom row w/ infobar in OOPIF @msedge-dev-macos-latest
❌ [chromium-library] › library/headful.spec.ts:30 › should close browser with beforeunload page @msedge-macos-latest
❌ [chromium-library] › library/headful.spec.ts:69 › should click when viewport size is larger than screen @msedge-macos-latest
❌ [chromium-library] › library/headful.spec.ts:84 › should dispatch click events to oversized viewports @msedge-macos-latest
❌ [chromium-library] › library/headful.spec.ts:213 › Page.bringToFront should work @msedge-macos-latest
❌ [chromium-library] › library/headful.spec.ts:252 › should click bottom row w/ infobar in OOPIF @msedge-macos-latest
❌ [webkit-page] › page/page-click.spec.ts:251 › should click on checkbox input and toggle @webkit-headed-windows-latest
❌ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:107 › should print load/save storage_state @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:139 › should work with --save-har @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:149 › should work with --save-har and --save-har-glob @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:36 › should print the correct context options for custom settings @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:62 › should print the correct context options when using a device and additional options @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:76 › should save the codegen output to a file if specified @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:57 › should print the correct context options when using a device and additional options @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:72 › should print load storageState @webkit-macos-13-xlarge

85 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284 › should click `@channel-chromium-macos-latest`
⚠️ [chromium-page] › page/workers.spec.ts:150 › should report network activity `@channel-chromium-macos-latest`
⚠️ [chromium-page] › page/workers.spec.ts:271 › should support extra http headers `@channel-chromium-macos-latest`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1319 › should pick locator in iframe `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:206 › screencast › should continue recording main page after popup closes `@chrome-macos-latest`
⚠️ [chromium-page] › page/workers.spec.ts:25 › Page.workers @smoke `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:270 › reuse connect › should reset mouse position `@chromium-headed-ubuntu-24.04`
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@chromium-headed-windows-latest`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-headed-windows-latest`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1934 › should load trace from HTTP with progress indicator `@chromium-macos-14-large`
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:94 › cli codegen › should click twice `@chromium-tip-of-tree-macos-13`
⚠️ [chromium-page] › page/page-aria-snapshot-ai.spec.ts:375 › return empty snapshot when iframe is not loaded `@chromium-tip-of-tree-macos-13`
⚠️ [chromium-page] › page/workers.spec.ts:25 › Page.workers @smoke `@chromium-tip-of-tree-macos-13`
⚠️ [chromium-page] › page/workers.spec.ts:150 › should report network activity `@chromium-tip-of-tree-macos-13`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-beta-macos-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:76 › should update aria snapshot highlight `@firefox-beta-macos-latest`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-beta-macos-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-beta-ubuntu-22.04`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-beta-windows-latest`
⚠️ [firefox-library] › library/capabilities.spec.ts:244 › requestFullscreen `@firefox-headed-macos-14-xlarge`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-headed-macos-14-xlarge`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-headed-macos-14-xlarge`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-headed-ubuntu-24.04`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1086 › cli codegen › should clear when recording is disabled `@firefox-headed-ubuntu-24.04`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:988 › should show action source `@firefox-headed-ubuntu-24.04`
⚠️ [firefox-page] › page/expect-misc.spec.ts:565 › toBeInViewport › should have good stack `@firefox-headed-ubuntu-24.04`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:274 › should work with offline option `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies.spec.ts:378 › should parse cookie with large Max-Age correctly `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/browsercontext-service-worker-policy.spec.ts:26 › block › blocks service worker registration `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/hit-target.spec.ts:366 › should detect overlaid element in a transformed iframe `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:94 › cli codegen › should click twice `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:310 › cli codegen › should generate frame locators with special characters in name attribute `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:245 › should print a valid basic program in mstest `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1357 › should highlight locator in iframe while typing `@firefox-headed-windows-latest`
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20 › should timeout waiting for stable position `@firefox-headed-windows-latest`
⚠️ [firefox-page] › page/page-click.spec.ts:251 › should click on checkbox input and toggle `@firefox-headed-windows-latest`
⚠️ [firefox-page] › page/page-mouse.spec.ts:174 › should select the text with mouse `@firefox-headed-windows-latest`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-headed-windows-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-macos-13-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456 › cli codegen › should save assets via SIGINT `@firefox-macos-13-large`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-macos-13-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-macos-13-xlarge`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-macos-14-large`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-macos-14-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-macos-14-xlarge`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-macos-14-xlarge`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-24.04`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:114 › reuse launch › should reset serviceworker `@firefox-windows-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-windows-latest`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-windows-latest`
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1263 › should work with connectOverCDP `@msedge-beta-macos-latest`
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:303 › reuse connect › should reset tracing `@msedge-beta-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:378 › screencast › should capture navigation `@msedge-beta-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:579 › screencast › should capture static page in persistent context @smoke `@msedge-beta-macos-latest`
⚠️ [chromium-page] › page/workers.spec.ts:25 › Page.workers @smoke `@msedge-beta-macos-latest`
⚠️ [chromium-library] › library/client-certificates.spec.ts:280 › browser › should keep supporting http `@msedge-beta-windows-latest`
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:150 › reuse launch › should reset serviceworker that hangs in importScripts `@msedge-dev-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:378 › screencast › should capture navigation `@msedge-dev-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:579 › screencast › should capture static page in persistent context @smoke `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:103 › should set cookie for top-level domain `@msedge-ubuntu-22.04`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@service`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@tracing-firefox`
⚠️ [firefox-library] › library/page-close.spec.ts:40 › expect should not print timed out error message when page closes `@tracing-firefox`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@tracing-firefox`
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:874 › cli codegen › should attribute navigation to press/fill `@webkit-headed-ubuntu-24.04`
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:53 › cli codegen › should double click `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:385 › cli codegen › should fill textarea `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:593 › cli codegen › should check a radio button `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:718 › cli codegen › should select with size attribute `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:819 › cli codegen › should attribute navigation to click `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:524 › cli codegen › should generate getByPlaceholder `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:553 › cli codegen › should generate getByAltText `@webkit-headed-windows-latest`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1319 › should pick locator in iframe `@webkit-macos-13-large`
⚠️ [webkit-library] › library/video.spec.ts:378 › screencast › should capture navigation `@webkit-macos-13-large`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:1052 › launchServer only › should work with existing browser `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:80 › should save the codegen output to a file if specified `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:125 › should work with --save-har `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:135 › should work with --save-har and --save-har-glob `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:20 › should print the correct imports and context options `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:30 › should print the correct context options for custom settings `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:96 › should generate routeFromHAR with --save-har `@webkit-macos-13-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:226 › cli codegen › should generate frame locators (4) `@webkit-macos-14-large`
⚠️ [webkit-page] › page/wheel.spec.ts:70 › should dispatch wheel events after context menu was opened `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/wheel.spec.ts:101 › should dispatch wheel events after popup was opened @smoke `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1546 › should not record network actions `@webkit-ubuntu-24.04`

243055 passed, 9669 skipped, 2984 did not run


Merge workflow run.

@dgozman
Copy link
Contributor Author

dgozman commented Sep 25, 2025

Hmm... This fails on mac with infobars.

Actually, this fails on mac where viewport size is larger than the screen size (easy to trigger on the bots), and the window is immediately considered to be maximized.

@dgozman dgozman closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants