-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: use new Browser.setContentSize protocol call #37423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but the tests are unhappy :-(
14d1064
to
877ee15
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hmm... This fails on mac with infobars. |
This one takes care of instes/infobars/etc on all platforms.
877ee15
to
bb0497a
Compare
Test results for "tests 1"2 failed 1 flaky46903 passed, 821 skipped Merge workflow run. |
Test results for "tests others"2 fatal errors, not part of any test 1 interrupted21611 passed, 474 skipped, 851 did not run Merge workflow run. |
Test results for "tests 2"2 fatal errors, not part of any test 85 flaky243055 passed, 9669 skipped, 2984 did not run Merge workflow run. |
Actually, this fails on mac where viewport size is larger than the screen size (easy to trigger on the bots), and the window is immediately considered to be maximized. |
This one takes care of insets/infobars/etc on all platforms.
Introduced to CPD in Chromium 140.
#37273