Skip to content

chore(chromium): use Brorwser.setContentsSize to resize window #37428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(chromium): use Brorwser.setContentsSize to resize window #37428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 30 additions & 20 deletions packages/playwright-core/src/server/chromium/crPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,27 +1017,37 @@ class FrameSession {
return;
const promises = [];
if (!preserveWindowBoundaries && this._windowId) {
let insets = { width: 0, height: 0 };
if (this._crPage._browserContext._browser.options.headful) {
// TODO: popup windows have their own insets.
insets = { width: 24, height: 88 };
if (process.platform === 'win32')
insets = { width: 16, height: 88 };
else if (process.platform === 'linux')
insets = { width: 8, height: 85 };
else if (process.platform === 'darwin')
insets = { width: 2, height: 80 };
if (this._crPage._browserContext.isPersistentContext()) {
// FIXME: Chrome bug: OOPIF router is confused when hit target is
// outside browser window.
// Account for the infobar here to work around the bug.
insets.height += 46;
const version = this._crPage._browserContext._browser.version();
const browserMajorVersion = parseInt(version.split('.')[0], 10);
if (browserMajorVersion >= 140) {
promises.push(this._client.send('Browser.setContentsSize', {
windowId: this._windowId,
width: viewportSize.width,
height: viewportSize.height,
}));
} else {
let insets = { width: 0, height: 0 };
if (this._crPage._browserContext._browser.options.headful) {
// TODO: popup windows have their own insets.
insets = { width: 24, height: 88 };
if (process.platform === 'win32')
insets = { width: 16, height: 88 };
else if (process.platform === 'linux')
insets = { width: 8, height: 85 };
else if (process.platform === 'darwin')
insets = { width: 2, height: 80 };
if (this._crPage._browserContext.isPersistentContext()) {
// FIXME: Chrome bug: OOPIF router is confused when hit target is
// outside browser window.
// Account for the infobar here to work around the bug.
insets.height += 46;
}
}
promises.push(this._setWindowBounds({
width: viewportSize.width + insets.width,
height: viewportSize.height + insets.height
}));
}
promises.push(this.setWindowBounds({
width: viewportSize.width + insets.width,
height: viewportSize.height + insets.height
}));
}
// Make sure that the viewport emulationis set after the embedder window resize.
promises.push(this._client.send('Emulation.setDeviceMetricsOverride', metricsOverride));
Expand All @@ -1052,7 +1062,7 @@ class FrameSession {
return bounds;
}

async setWindowBounds(bounds: WindowBounds) {
private async _setWindowBounds(bounds: WindowBounds) {
return await this._client.send('Browser.setWindowBounds', {
windowId: this._windowId!,
bounds
Expand Down
Loading