-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(ui-mode): prevent navigation inside UI Mode app #37437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
97c96de
to
b435227
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what are you trying to do?
A small question: does it only prevent going back in the standalone UI mode? I think this fix should not be preventing navigation in UI run in local browser and especially in trace viewer when viewing reports ( |
This comment has been minimized.
This comment has been minimized.
…i-mode-history-back-fix
Test results for "tests 1"12 fatal errors, not part of any test 2 flaky37769 passed, 764 skipped, 388 did not run Merge workflow run. |
Fixes #37419
Our "apps" are simple browser wrappers (generally Chromium) and as such have history. Do our best to prevent history changes in JS (note this isn't foolproof and only works most of the time).