fix(ui): add WSL GPU rendering workarounds for transparent UI windows #37481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d PW_UI_DISABLE_GPU=1 to force --disable-gpu\n- Add PW_UI_USE_SWIFTSHADER=1 to force --use-gl=swiftshader\n- Default to SwiftShader on WSL to avoid transparent window\n\nFixes: microsoft#37287
Add environment variable controls and automatic WSL detection to resolve transparent window issues in Playwright UI mode when running under WSL with Intel iGPU and discrete GPU configurations. Environment variables (in order of precedence): - PW_UI_DISABLE_GPU=1: Force disable GPU entirely - PW_UI_USE_SWIFTSHADER=1: Force SwiftShader software rendering - PW_UI_USE_DISCRETE_GPU=1: Force discrete GPU selection - Auto-detect WSL and use SwiftShader as fallback This addresses the issue where Playwright UI mode opens with a completely transparent window in WSL environments with mixed GPU configurations, making the UI unusable. Fixes microsoft#37287
- Update tests to verify Playwright UI loads correctly instead of test page content - Check for [data-testid="test-tree"] element which indicates UI mode is working - Tests now properly validate that UI mode launches with different rendering options - Fixes test failures where tests were looking for test page content in UI mode
- Extract WSL rendering logic into dedicated helper functions - Add comprehensive JSDoc documentation for better maintainability - Simplify test code with reusable helper functions - Reduce code duplication and improve readability - Maintain all existing functionality while making code more maintainable The refactored code is cleaner, more testable, and easier to understand while preserving all the original WSL rendering workaround functionality.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Remove temporary file creation that caused Windows compatibility issues - Mock fs.existsSync directly instead of creating /tmp/WSLInterop file - Test now works cross-platform including Windows
Contributor
Test results for "tests 1"5 flaky46955 passed, 821 skipped Merge workflow run. |
Contributor
|
Thank you for the PR! We've decided fixing this is not worth the complexity. See this comment. Again, thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37287