chore(bidi): add support for context locators #38129
Open
+52
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses BiDi context locators to implement
Frame.frameElement()and to fetch a frame'sname(orid) attribute.For the latter I ran into two timing issues:
FrameManager.frameCommittedNewDocumentNavigation()needs to be called synchronously when the navigation is committed because it removes the old child frames, so if we wait for the frame's name to be fetched before calling it, we may remove child frames that were added after the navigation. I fixed this by calling it synchronously, passing a Promise for the name to it and awaiting that Promise only after deleting the child frames.domcontentloadedandloadevents should only be fired after all child frame names have been fetched, otherwise a test may request a child frame by name before that name has been fetched.The PR fixes the following tests in Firefox:
tests/library/hit-target.spec.ts:tests/page/elementhandle-bounding-box.spec.ts:tests/page/frame-frame-element.spec.ts:tests/page/frame-hierarchy.spec.ts: