Skip to content

chore: disable infobars in Chromium #38146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: disable infobars in Chromium #38146

wants to merge 1 commit into from
+3 −0

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Nov 7, 2025

This is to get rid of the Chrome for Testing infobar that's visible for the persistent context.

@dgozman dgozman requested a review from yury-s November 7, 2025 16:02
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
yury-s
yury-s approved these changes Nov 7, 2025
View reviewed changes
packages/playwright-core/src/server/chromium/chromiumSwitches.ts
// Edge can potentially restart on Windows (msRelaunchNoCompatLayer) which looses its file descriptors (stdout/stderr) and CDP (3/4). Disable until fixed upstream.
'--edge-skip-compat-layer-relaunch',
assistantMode ? '' : '--enable-automation',
'--disable-infobars',
Copy link
Member

@yury-s yury-s Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that it doesn't affect vendor builds.

@dgozman
chore: disable infobars in Chromium
1f0d609 
This is to get rid of the Chrome for Testing infobar
that's visible for the persistent context.
@dgozman dgozman force-pushed the chore-chromium-disable-infobars branch from 064c94a to 1f0d609 Compare November 7, 2025 22:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Test results for "MCP"

1 failed
❌ [chrome] › mcp/sse.spec.ts:233 › sse transport shared context @mcp-macos-15

2587 passed, 116 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Test results for "tests 1"

72 failed
❌ [default] › decorations.spec.ts:19 › should highlight steps while running @vscode-extension
❌ [default] › run-annotations.spec.ts:19 › should mark test as skipped @vscode-extension
❌ [default] › run-tests.spec.ts:22 › should run all tests @vscode-extension
❌ [default] › run-tests.spec.ts:66 › should run one test @vscode-extension
❌ [default] › run-tests.spec.ts:143 › should run file @vscode-extension
❌ [default] › run-tests.spec.ts:181 › should run folder @vscode-extension
❌ [default] › run-tests.spec.ts:323 › should only create test run if file belongs to context @vscode-extension
❌ [default] › run-tests.spec.ts:383 › should only create test run if folder belongs to context @vscode-extension
❌ [default] › run-tests.spec.ts:428 › should run all projects at once @vscode-extension
❌ [default] › run-tests.spec.ts:461 › should group projects by config @vscode-extension
❌ [default] › run-tests.spec.ts:581 › should run all parametrized tests @vscode-extension
❌ [default] › run-tests.spec.ts:639 › should run one parametrized test @vscode-extension
❌ [default] › run-tests.spec.ts:680 › should run one parametrized groups @vscode-extension
❌ [default] › run-tests.spec.ts:735 › should run tests in parametrized groups @vscode-extension
❌ [default] › run-tests.spec.ts:839 › should filter selected project @vscode-extension
❌ [default] › run-tests.spec.ts:1041 › should produce output twice @vscode-extension
❌ [default] › source-map.spec.ts:222 › should run all tests @vscode-extension
❌ [default] › source-map.spec.ts:255 › should run one test @vscode-extension
❌ [default] › watch.spec.ts:22 › should watch all tests @vscode-extension
❌ [default] › watch.spec.ts:89 › should unwatch all tests @vscode-extension
❌ [default] › watch.spec.ts:200 › should watch tests via helper @vscode-extension
❌ [default] › watch.spec.ts:260 › should watch one test in a file @vscode-extension
❌ [default] › watch.spec.ts:338 › should watch two tests in a file @vscode-extension
❌ [default] › watch.spec.ts:492 › should only watch a test from the enabled project when multiple projects share the same test directory @vscode-extension
❌ [default-reuse] › decorations.spec.ts:19 › should highlight steps while running @vscode-extension
❌ [default-reuse] › run-annotations.spec.ts:19 › should mark test as skipped @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:22 › should run all tests @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:66 › should run one test @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:143 › should run file @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:181 › should run folder @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:323 › should only create test run if file belongs to context @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:383 › should only create test run if folder belongs to context @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:428 › should run all projects at once @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:461 › should group projects by config @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:581 › should run all parametrized tests @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:639 › should run one parametrized test @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:680 › should run one parametrized groups @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:735 › should run tests in parametrized groups @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:839 › should filter selected project @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:1041 › should produce output twice @vscode-extension
❌ [default-reuse] › source-map.spec.ts:222 › should run all tests @vscode-extension
❌ [default-reuse] › source-map.spec.ts:255 › should run one test @vscode-extension
❌ [default-reuse] › watch.spec.ts:22 › should watch all tests @vscode-extension
❌ [default-reuse] › watch.spec.ts:89 › should unwatch all tests @vscode-extension
❌ [default-reuse] › watch.spec.ts:200 › should watch tests via helper @vscode-extension
❌ [default-reuse] › watch.spec.ts:260 › should watch one test in a file @vscode-extension
❌ [default-reuse] › watch.spec.ts:338 › should watch two tests in a file @vscode-extension
❌ [default-reuse] › watch.spec.ts:492 › should only watch a test from the enabled project when multiple projects share the same test directory @vscode-extension
❌ [default-trace] › decorations.spec.ts:19 › should highlight steps while running @vscode-extension
❌ [default-trace] › run-annotations.spec.ts:19 › should mark test as skipped @vscode-extension
❌ [default-trace] › run-tests.spec.ts:22 › should run all tests @vscode-extension
❌ [default-trace] › run-tests.spec.ts:66 › should run one test @vscode-extension
❌ [default-trace] › run-tests.spec.ts:143 › should run file @vscode-extension
❌ [default-trace] › run-tests.spec.ts:181 › should run folder @vscode-extension
❌ [default-trace] › run-tests.spec.ts:323 › should only create test run if file belongs to context @vscode-extension
❌ [default-trace] › run-tests.spec.ts:383 › should only create test run if folder belongs to context @vscode-extension
❌ [default-trace] › run-tests.spec.ts:428 › should run all projects at once @vscode-extension
❌ [default-trace] › run-tests.spec.ts:461 › should group projects by config @vscode-extension
❌ [default-trace] › run-tests.spec.ts:581 › should run all parametrized tests @vscode-extension
❌ [default-trace] › run-tests.spec.ts:639 › should run one parametrized test @vscode-extension
❌ [default-trace] › run-tests.spec.ts:680 › should run one parametrized groups @vscode-extension
❌ [default-trace] › run-tests.spec.ts:735 › should run tests in parametrized groups @vscode-extension
❌ [default-trace] › run-tests.spec.ts:839 › should filter selected project @vscode-extension
❌ [default-trace] › run-tests.spec.ts:1041 › should produce output twice @vscode-extension
❌ [default-trace] › source-map.spec.ts:222 › should run all tests @vscode-extension
❌ [default-trace] › source-map.spec.ts:255 › should run one test @vscode-extension
❌ [default-trace] › watch.spec.ts:22 › should watch all tests @vscode-extension
❌ [default-trace] › watch.spec.ts:89 › should unwatch all tests @vscode-extension
❌ [default-trace] › watch.spec.ts:200 › should watch tests via helper @vscode-extension
❌ [default-trace] › watch.spec.ts:260 › should watch one test in a file @vscode-extension
❌ [default-trace] › watch.spec.ts:338 › should watch two tests in a file @vscode-extension
❌ [default-trace] › watch.spec.ts:492 › should only watch a test from the enabled project when multiple projects share the same test directory @vscode-extension

4 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@chromium-ubuntu-22.04-node18`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165 › should update tracing network live `@ubuntu-latest-node20-2`

40249 passed, 789 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @yury-s