Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the std::in_place_type_t overload for SFINAE-unsafe facades #223

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Dec 20, 2024

This change explicitly excludes proxy(P&& ptr) from overload resolution if P is a (possibly cv-qualified) specialization of std::in_place_type_t. It aligns with the implementation of std::any in MSVC and libstdc++.

Note that Clang 15 could not handle the situation where concepts are mixed with SFINAE. The test case will still fail in Clang 15. Since it is not trivial to work around, I removed support for Clang 15 from our pipeline and README for now. (See the previous CI build).

Resolves #222. Another unit test case was added accordingly.

@mingxwa mingxwa requested review from tian-lt and guominrui December 20, 2024 07:25
@mingxwa mingxwa merged commit 248e8cf into microsoft:main Dec 23, 2024
7 checks passed
@mingxwa mingxwa deleted the user/mingxwa/in_place_type branch December 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::in_place_type_t overload broken when a dispatch is not SFINAE-safe
2 participants