Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check for folderFiles in findJSBundleInUpdateContents to avoid c… #2309

Closed

Conversation

saket-bm-ai
Copy link

…rash in android

@ghost
Copy link

ghost commented Jul 25, 2022

CLA assistant check
All CLA requirements met.

@saket-bm-ai saket-bm-ai requested a review from a team as a code owner January 18, 2024 13:18
@DmitriyKirakosyan
Copy link
Contributor

Hi @saket-bm-ai,

Are you still interested in this PR? Did you encounter this crash locally or in the release version? folder.listFiles() can return null if folder is not a directory. I'm curious about the scenario where this might happen.

@DmitriyKirakosyan
Copy link
Contributor

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants