Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DevSettingsActivity from main to debug #2562

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

floydkim
Copy link
Contributor

@floydkim floydkim commented Aug 12, 2023

closes: #2353

Tests

  • npm run test:android
  • building app, installing code-push bundle
    • on production Android app (RN 0.67.5, with same modification on react-native-code-push@7.0.4 package using patch-package)
  • DevSettingsActivity not found in manifest-merger-release-report.txt

For anyone looking for a patch for this issue, here it is.
diff --git a/node_modules/react-native-code-push/android/app/src/debug/AndroidManifest.xml b/node_modules/react-native-code-push/android/app/src/debug/AndroidManifest.xml
new file mode 100644
index 0000000..5bd1596
--- /dev/null
+++ b/node_modules/react-native-code-push/android/app/src/debug/AndroidManifest.xml
@@ -0,0 +1,10 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.microsoft.codepush.react">
+
+    <uses-permission android:name="android.permission.INTERNET" />
+
+    <application>
+        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
+    </application>
+
+</manifest>
\ No newline at end of file
diff --git a/node_modules/react-native-code-push/android/app/src/main/AndroidManifest.xml b/node_modules/react-native-code-push/android/app/src/main/AndroidManifest.xml
index 5bd1596..9b2755f 100644
--- a/node_modules/react-native-code-push/android/app/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-code-push/android/app/src/main/AndroidManifest.xml
@@ -3,8 +3,4 @@
 
     <uses-permission android:name="android.permission.INTERNET" />
 
-    <application>
-        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
-    </application>
-
 </manifest>

@floydkim floydkim requested a review from a team as a code owner August 12, 2023 10:27
@floydkim
Copy link
Contributor Author

@microsoft-github-policy-service agree

@DmitriyKirakosyan
Copy link
Contributor

Hi @floydkim, merging this PR would mean you will be updating the react-native-code-push package to latest version once it is released. I would recommend trying to update it to the current latest version 8.2.2 and test if it works with your react-native@0.67 project. Since version 0.67 is archived, I also recommend migrating to a newer React Native version if you haven't done so yet.

@floydkim
Copy link
Contributor Author

floydkim commented Jun 4, 2024

hello! @DmitriyKirakosyan
It's been about 10 months since I created this PR and the app I'm working on is now using react-native 0.73 with react-native-code-push@8.2.1 based package.
If this PR is merged, I'd be happy to test the new release on the app.
Thank you.

@DmitriyKirakosyan
Copy link
Contributor

Also related #2658

@DmitriyKirakosyan DmitriyKirakosyan merged commit c4b293d into microsoft:master Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security issue: DevSettings Screen available in release react native android app.
6 participants