Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codepush.gradle: fix Could not find matching constructor for: … #2649

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Update codepush.gradle: fix Could not find matching constructor for: … #2649

merged 2 commits into from
Jan 25, 2024

Conversation

hamdij0maa
Copy link
Contributor

./gradlew clean
fix Could not find matching constructor for java.io.File(File). Fixes : #2648

@hamdij0maa hamdij0maa requested a review from a team as a code owner January 19, 2024 15:34
@hamdij0maa hamdij0maa mentioned this pull request Jan 19, 2024
Closed
mizinin
mizinin reviewed Jan 19, 2024
View reviewed changes
android/codepush.gradle Outdated Show resolved Hide resolved
@hamdij0maa @mizinin
Update android/codepush.gradle
89d3ea6 
Co-authored-by: Artem Mizinin <mizinin@users.noreply.github.com>
@GSTJ GSTJ mentioned this pull request Jan 20, 2024
Closed
@GSTJ
Copy link

GSTJ commented Jan 20, 2024

Needing this for GSTJ/react-native-code-push-plugin#4

@mgscreativa
Copy link

mgscreativa commented Jan 22, 2024 •
edited
Loading

Hi! I confirm that after applying this PR my app builds ok on android and RN 73

@neutrino2211
Copy link

I manually made the proposed changes in a RN 72 project and it seems to work. Is there anything holding this back from being pushed to NPM? It's delaying my team's ability to compile new APKs

@BogdaKusch
Copy link

I manually made the proposed changes in a RN 72 project and it seems to work. Is there anything holding this back from being pushed to NPM? It's delaying my team's ability to compile new APKs

you can use patch-package for now 😄

@larsmunkholm larsmunkholm mentioned this pull request Jan 23, 2024
Merged
@GSTJ
Copy link

GSTJ commented Jan 23, 2024

Captura de Tela 2024-01-23 às 11 45 50

Something's up with CI.

@AnatolyPristensky AnatolyPristensky merged commit 82c54a4 into microsoft:master Jan 25, 2024
3 checks passed
@mgscreativa
Copy link

¿Is it possible to do a new release so this change gets published to npmJS?

@AnatolyPristensky AnatolyPristensky mentioned this pull request Jan 26, 2024
Merged
@AnatolyPristensky
Copy link
Contributor

¿Is it possible to do a new release so this change gets published to npmJS?

Hello, @mgscreativa, this release is already on npmJS - https://www.npmjs.com/package/react-native-code-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mizinin mizinin mizinin left review comments

@DmitriyKirakosyan DmitriyKirakosyan DmitriyKirakosyan approved these changes

@lucen-ms lucen-ms lucen-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@hamdij0maa @GSTJ @mgscreativa @neutrino2211 @BogdaKusch @AnatolyPristensky @DmitriyKirakosyan @mizinin @lucen-ms