Skip to content

Conversation

anupriya13
Copy link
Contributor

@anupriya13 anupriya13 commented Sep 29, 2025

Description

The following commits identified as root causes for issue #15177 were reverted:

6bd0793 [Fabric] Implement snapToAlignment property for ScrollView (#14841)
2cde3f1 [Fabric] Implement snapToInterval property for ScrollView (#14847)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

To fix scrollview recent regression
Revert commits to fix ScrollView regression

Resolves #15171 and #15177

What

Revert 6bd0793 and 2cde3f1

Testing

Interestingly the bugs was not repro in playground then I found out a way to attach canary builds in gallery and tested there.

Below are the 4 commits made on scrollview:

2969c7b
2198313
2cde3f1
6bd0793

I tested in gallery from canary builds and found it's regressing after 2cde3f1

0.0.0-canary.969 -> OK -> 2969c7b

0.0.0-canary.970 -> OK -> 2198313

0.0.0-canary.974 -> BUG -> 2cde3f1

Most likely it's due to this line: https://github.com/microsoft/react-native-windows/blob/2cde3f11b7c67db52b6b56203cc3df560ac48ea7/vne…

To unblock release I will revert that commit.

But commit 6bd0793 is dependent on prev (2cde3f1) so will have to revert that too.

Hence reverting 2 commits and will pick up in future: snapToAlignment and snapToInterval

Changelog

Should this change be included in the release notes: no

Add a brief summary of the change to use in the release notes for the next release.

@anupriya13 anupriya13 linked an issue Sep 29, 2025 that may be closed by this pull request
@anupriya13 anupriya13 marked this pull request as ready for review September 29, 2025 03:19
@anupriya13 anupriya13 requested review from a team as code owners September 29, 2025 03:19
Copy link
Contributor

@vineethkuttan vineethkuttan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found only revert changes.
LGTM!

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Sep 30, 2025

@anupriya13 Please fix the PR title with a short summary. Compare these existing commit messages:

$ git log --oneline -4

acff7e8ef Update compression and on-headers package (#15002)
6d910885e Create .github/copilot-instructions.md file for React Native Windows (#14987) (#14988)
16aba2428 Update ReadMe for Release Notes Generation Script (#14989)
270f785bd Revert "Change `init-windows` default new app template to New Architecture" (#14985)

with

8badf00d Revert 6bd0793c1a9e2afd31ac1f00d3b0eb5bb8138e1f and 2cde3f11b7c67db52b6b56203cc3df560ac48ea7 (#15182)

It isn't descriptive of what changed due to this commit.


A title (+ body) can be

8badf00d Revert commits to fix ScrollView regression

The following commits identified as root causes for issue #blah were reverted:

6bd0793 [Fabric] Implement snapToAlignment property for ScrollView  (#14841)
2cde3f11 [Fabric] Implement snapToInterval property for ScrollView  (#14847)

Raised a bug #beep to take these commits back for said props.

A good commit message

  • Captures the why (context) than how / what (which git diff can always show)
  • Is succinct.

Please refer How to Write a Git Commit Message.

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Sep 30, 2025

Please drop template strings from PR description given for your guidance but not to pollute commit messages.

## Description

### Type of Change
- Bug fix (non-breaking change which fixes an issue)

### Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
To fix scrollview recent regression
Resolves https://github.com/microsoft/react-native-windows/issues/15171 and https://github.com/microsoft/react-native-windows/issues/15177

should be

# Description

## Type of Change
Bug fix (non-breaking change which fixes an issue)

## Why
To fix scrollview recent regression.  Resolves #15171 and #15177.

Which of these would you rather read?

These template strings are just noise. Compare these messages with PRs from mature developers and notice the difference:

#14713 by Andrew
#15013 by Jon

Copy link
Contributor

@sundaramramaswamy sundaramramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix aforementioned comments.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Sep 30, 2025
@anupriya13 anupriya13 changed the title Revert 6bd0793c1a9e2afd31ac1f00d3b0eb5bb8138e1f and 2cde3f11b7c67db52b6b56203cc3df560ac48ea7 Revert commits to fix ScrollView regression Sep 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Sep 30, 2025
@anupriya13
Copy link
Contributor Author

@sundaramramaswamy updated please check

@anupriya13 anupriya13 merged commit 63e9eaa into microsoft:main Sep 30, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse scroll wheel does not scroll Infinite scrolling up/down from ScrollView in 0.80 preview 6 (regression from 0.79)
3 participants