-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Revert commits to fix ScrollView regression #15182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert commits to fix ScrollView regression #15182
Conversation
…icrosoft#14841)" This reverts commit 6bd0793.
…crosoft#14847)" This reverts commit 2cde3f1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found only revert changes.
LGTM!
@anupriya13 Please fix the PR title with a short summary. Compare these existing commit messages:
with
It isn't descriptive of what changed due to this commit. A title (+ body) can be
A good commit message
Please refer How to Write a Git Commit Message. |
Please drop template strings from PR description given for your guidance but not to pollute commit messages.
should be
Which of these would you rather read? These template strings are just noise. Compare these messages with PRs from mature developers and notice the difference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix aforementioned comments.
@sundaramramaswamy updated please check |
Description
The following commits identified as root causes for issue #15177 were reverted:
6bd0793 [Fabric] Implement snapToAlignment property for ScrollView (#14841)
2cde3f1 [Fabric] Implement snapToInterval property for ScrollView (#14847)
Type of Change
Why
To fix scrollview recent regression
Revert commits to fix ScrollView regression
Resolves #15171 and #15177
What
Revert 6bd0793 and 2cde3f1
Testing
Interestingly the bugs was not repro in playground then I found out a way to attach canary builds in gallery and tested there.
Below are the 4 commits made on scrollview:
2969c7b
2198313
2cde3f1
6bd0793
I tested in gallery from canary builds and found it's regressing after 2cde3f1
0.0.0-canary.969 -> OK -> 2969c7b
0.0.0-canary.970 -> OK -> 2198313
0.0.0-canary.974 -> BUG -> 2cde3f1
Most likely it's due to this line: https://github.com/microsoft/react-native-windows/blob/2cde3f11b7c67db52b6b56203cc3df560ac48ea7/vne…
To unblock release I will revert that commit.
But commit 6bd0793 is dependent on prev (2cde3f1) so will have to revert that too.
Hence reverting 2 commits and will pick up in future: snapToAlignment and snapToInterval
Changelog
Should this change be included in the release notes: no
Add a brief summary of the change to use in the release notes for the next release.