made fixes for translations, added support for levels, improved print… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed add_time_intel in tom, added is_calculated_table, ran black
eisber
requested changes
Jul 9, 2024
eisber
approved these changes
Jul 12, 2024
| @@ -1848,7 +1895,7 @@ def hybrid_tables(self): | |||
| if any(p.Mode == TOM.ModeType.DirectQuery for p in t.Partitions): | |||
| yield t | |||
|
|
|||
| def date_tables(self): | |||
| def all_date_tables(self): | |||
There was a problem hiding this comment.
if you rename methods (which breaks the API) you need to increase the major version
| @@ -121,9 +122,11 @@ def refresh_calc_tables(dataset: str, workspace: Optional[str] = None): | |||
| f"{icons.green_dot} Calculated table '{tName}' has been refreshed as the '{delta_table_name.lower()}' table in the lakehouse." | |||
| ) | |||
| except Exception as e: | |||
There was a problem hiding this comment.
for a separate PR, we should do a round of exception reviewing. I think there's still a bunch of cases, where you can check on a condition before hand and avoid just catching the exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…outs