Skip to content

Conversation

sheetalkamat
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings September 11, 2025 19:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where d.ts files from project references were incorrectly ignored during module resolution. The fix ensures that both TypeScript source files and declaration files are properly included when building composite projects with project references.

  • Renamed method to include both declaration and source files in the iteration
  • Updated logic to process both TypeScript source files and d.ts files appropriately
  • Added comprehensive test case covering project reference resolution scenarios
  • Improved whitespace handling in test utility function

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/tsoptions/parsedcommandline.go Updated method name and logic to include both d.ts and source files in project reference resolution
internal/compiler/fileloader.go Updated method call to use the renamed function for project reference file iteration
internal/testutil/stringtestutil/stringtestutil.go Enhanced Dedent function to handle all whitespace characters properly, not just tabs
internal/execute/tsctests/tsc_test.go Added comprehensive test case for project reference resolution from d.ts files
testdata/baselines/reference/tsbuild/moduleResolution/resolution-from-d.ts-of-referenced-project.js Generated test baseline showing expected behavior for the new test case

@sheetalkamat sheetalkamat added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit 4c9b8f6 Sep 11, 2025
22 checks passed
@sheetalkamat sheetalkamat deleted the dtsProjectReference branch September 11, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants