Port "Account for right operands & fix a weird error message for leftmost nullish literals in checkNullishCoalesceOperands" #1805
+73
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…most nullish literals in checkNullishCoalesceOperands" Co-authored-by: Chiri Vulpes <github@chiri.works>
jakebailey
reviewed
Oct 3, 2025
|
|
||
| func (c *Checker) checkNullishCoalesceOperandRight(right *ast.Node) { | ||
| binaryExpression := right.Parent | ||
| if binaryExpression.Parent != nil && ast.IsBinaryExpression(binaryExpression.Parent) && binaryExpression.Parent.AsBinaryExpression().OperatorToken.Kind == ast.KindQuestionQuestionToken { |
There was a problem hiding this comment.
Is retaining isNotWithinNullishCoalesceExpression too annoying?
There was a problem hiding this comment.
it's not like super annoying, but it's a rather straightforward check and it was only used in this single place so I decided to inline it
jakebailey
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#59569