feat(http-client-csharp): add InputOperation.OperationId
#5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
archerzz
force-pushed
the
http-client-csharp/add-operation-id
branch
from
45c7044 to
994d614
Compare
|
API change check API changes are not detected in this pull request. |
- add `InputOperation.OperationId` - invoke `resolveOperationId()` to initialize it part of Azure/autorest.csharp#5117
archerzz
force-pushed
the
http-client-csharp/add-operation-id
branch
from
994d614 to
de848fc
Compare
archerzz
commented
Jan 6, 2025
| @@ -74,6 +75,7 @@ export function fromSdkServiceMethod( | |||
| getResourceOperation(sdkContext.program, method.operation.__raw.operation)?.resourceType | |||
| .name ?? | |||
| getOperationGroupName(sdkContext, method.operation, sdkContext.sdkPackage.rootNamespace), | |||
| OperationId: resolveOperationId(sdkContext.program, method.operation.__raw.operation), | |||
There was a problem hiding this comment.
there are 3 ways to resolve the operation id:
@typespec/openapiwill use the original resource name, e.g. ignoring renaming by@clientName:typespec/packages/openapi/src/helpers.ts
Line 137 in ecf61f1
@typespec-azure/typespec-generator-client-corewill honor renaming: https://github.com/Azure/typespec-azure/blob/9d16af124e507f7194d4f378637c9ca557bd6d2e/packages/typespec-client-generator-core/src/example.ts#L142@typespec-azure/typespec-autorestwill honor renaming and make it pascal: https://github.com/Azure/typespec-azure/blob/9d16af124e507f7194d4f378637c9ca557bd6d2e/packages/typespec-autorest/src/utils.ts#L72
I thought we should use option 1 which should be closest to original operation id in swagger. Any thought?
microsoft-github-policy-service
bot
added
the
stale
|
Hi @archerzz. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputOperation.OperationIdresolveOperationId()to initialize itpart of Azure/autorest.csharp#5117