Merge EFv2 work to main #5798
Merge EFv2 work to main #5798
Conversation
| import { isTemplateInstance } from "../../../core/type-utils.js"; | ||
| import { Enum, Interface, Model, Scalar, Union } from "../../../core/types.js"; | ||
|
|
||
| export function getPlausibleName(type: Model | Union | Enum | Scalar | Interface) { |
There was a problem hiding this comment.
@bterlson it seems strange to have this free-floating method here. Isn't that what typekits were created to alleviate? Should this be relocated somewhere or is it fine as-is?
| namespaces: Namespace[]; | ||
| } | ||
|
|
||
| export class TypeCollector { |
There was a problem hiding this comment.
@bterlson I think this was some work I had originally done long ago and doesn't really have anything to do with EFv2. Shall I remove it?
| } from "@typespec/compiler"; | ||
| import { $ } from "@typespec/compiler/typekit"; | ||
|
|
||
| export function isModel(type: any): type is Model { |
There was a problem hiding this comment.
@bterlson are these intended to work with typekits, or are these like an ancestor of them? Basically, should I keep these in or remove them?
| @@ -0,0 +1,56 @@ | |||
| { | |||
| "name": "@typespec/http-client-library", | |||
There was a problem hiding this comment.
@bterlson are you okay with renaming this http-client?
tjprescott
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin and
witemple-msft
as code owners
tjprescott
requested review from
joheredi and
bterlson
and removed request for
bterlson,
timotheeguerin,
markcowl,
allenjzhang and
witemple-msft
tjprescott
force-pushed
the
efv2merge
branch
2 times, most recently
from
3d55dfb to
51c68b5
Compare
| @@ -0,0 +1 @@ | |||
| export * from "./kits/index.js"; | |||
There was a problem hiding this comment.
@bterlson should this live in an "experimental" folder and namespace like it does for compiler and http?
Closes #5788.
TODO