-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yalantinglibs] Add a new port #42154
base: master
Are you sure you want to change the base?
Conversation
@171930433 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
I will convert this PR to a draft. After all CIs are green, you can click "ready for review". |
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) | ||
configure_file("${CMAKE_CURRENT_LIST_DIR}/usage" "${CURRENT_PACKAGES_DIR}/share/${PORT}/usage" COPYONLY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) | |
configure_file("${CMAKE_CURRENT_LIST_DIR}/usage" "${CURRENT_PACKAGES_DIR}/share/${PORT}/usage" COPYONLY) | |
file(INSTALL "${CURRENT_PORT_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") | |
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) |
and with a line break at the end.
yalantinglibs provides CMake targets: | ||
|
||
find_package(yalantinglibs CONFIG REQUIRED) | ||
target_link_libraries(main yalantinglibs::yalantinglibs) | ||
target_compile_features(main PRIVATE cxx_std_20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yalantinglibs provides CMake targets: | |
find_package(yalantinglibs CONFIG REQUIRED) | |
target_link_libraries(main yalantinglibs::yalantinglibs) | |
target_compile_features(main PRIVATE cxx_std_20) | |
yalantinglibs provides CMake targets: | |
find_package(yalantinglibs CONFIG REQUIRED) | |
target_link_libraries(main PRIVATE yalantinglibs::yalantinglibs) |
with a line break at the end.
If cxx_std_20
is a usage requirement, it doesn't belong into the usage file, but to the target properties, i.e. the package must handle it via PUBLIC
target compile options so that it becomes part of the exported properties.
No description provided.