Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spatial-hash] add new port #42197

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SeanTolstoyevski
Copy link

@SeanTolstoyevski SeanTolstoyevski commented Nov 16, 2024

  • Changes comply with the maintainer guide.

  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.

  • The versioning scheme in vcpkg.json matches what upstream says.

  • The license declaration in vcpkg.json matches what upstream says.

  • The installed as the "copyright" file matches what upstream says.

  • The source code of the component installed comes from an authoritative source.

  • The generated "usage text" is accurate. See adding-usage for context.

  • Only one version is in the new port's versions file.

  • Only one version is added to each modified port's versions file.

  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

I'm not sure I understand this question. So I don't know what the answer should be.

@SeanTolstoyevski SeanTolstoyevski changed the title add port: spatial-hash [spatial-hash] add new port Nov 16, 2024
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 18, 2024
ports/spatial-hash/portfile.cmake Outdated Show resolved Hide resolved
ports/spatial-hash/portfile.cmake Outdated Show resolved Hide resolved
@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft November 18, 2024 03:06
@SeanTolstoyevski SeanTolstoyevski marked this pull request as ready for review November 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants