Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Glob] add new port #43583

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[Glob] add new port #43583

wants to merge 4 commits into from
+61 −0

Conversation

EfesX
Copy link
Contributor

@EfesX EfesX commented Feb 1, 2025 •
edited
Loading

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Fixes #43534

@EfesX EfesX marked this pull request as draft February 1, 2025 18:06
dg0yt
dg0yt reviewed Feb 2, 2025
View reviewed changes
ports/glob/portfile.cmake
vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DFETCHCONTENT_FULLY_DISCONNECTED=OFF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. A port shall be able to build while fully disconnected, with cached source assets.

IIUC it needs CPM, and port stdexec might be an example how to provide CPM.cmake in vcpkg.

ports/glob/usage
Comment on lines +1 to +4
The package glob provides CMake targets:

find_package(Glob CONFIG REQUIRED)
target_link_libraries(main PRIVATE Glob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 


  find_package(Glob CONFIG REQUIRED)
  target_link_libraries(main PRIVATE Glob)

(Aligned with tool heuristics output.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] glob
2 participants
@EfesX @dg0yt