Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gnuld error parsing false positive on make errors, false negative due to trailing \r, and false parsing of new "multiple definitions" error #4341

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

0xemgy
Copy link
Contributor

@0xemgy 0xemgy commented Mar 9, 2025

Fix GNULD parsing issues:

  1. Do not detect false positive make errors when using Unix Makefiles as a generator.
  2. Detect "undefined reference" error with a trailing "\r".
  3. Parse "multiple definitions" error correctly with the first c file as file reference, and the second file as part of the error message.

… due to trailing \r, and false parsing of new "multiple definitions" error
Copy link
Collaborator

@gcampbell-msft gcampbell-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me, but please update the CHANGELOG to have your bug fix in the 1.21 section (just recently updated, sorry about that).

Also, please include a PR description as it helps with history.

@gcampbell-msft gcampbell-msft merged commit 7bbf261 into microsoft:main Mar 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants