Remove user shell prompt #1804
Merged
Remove user shell prompt #1804
+0
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed since the shell is described correctly in the run_in_terminal tool now Fixes microsoft/vscode#275638
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the user shell prompt information from the agent's context. The shell description is now handled by the run_in_terminal tool, eliminating the need for this global prompt. This addresses issue microsoft/vscode#275638.
Key changes:
- Removed the
UserShellPromptcomponent class that provided shell-specific instructions (zsh, PowerShell, fish) - Removed the corresponding JSX usage from the environment_info section
- Updated test snapshots to reflect the removed shell prompt text
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extension/prompts/node/agent/agentPrompt.tsx | Removed UserShellPrompt component class and its usage in the GlobalAgentContext render method; removed basename import |
| src/extension/prompts/node/agent/test/snapshots/*.snap | Updated test snapshots to remove the shell prompt line from environment_info sections |
lszomoru
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed since the shell is described correctly in the run_in_terminal tool now
Fixes microsoft/vscode#275638