Open
Conversation
Tatsinnit
reviewed
Jan 3, 2024
| "categories": [ | ||
| "Other" | ||
| ], | ||
| "capabilities": { |
Member
There was a problem hiding this comment.
❤️❤️☕️ Nice, this is step forward for this repo, also if it is ok can we please make sure about this specific aspect in this codebase https://github.com/microsoft/vscode/wiki/Virtual-Workspaces#review-that-the-code-is-ready-for-virtual-resources
Thank you so much.
hsubramanianaks
approved these changes
Jan 24, 2024
Collaborator
hsubramanianaks
left a comment
hsubramanianaks
left a comment
There was a problem hiding this comment.
looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 2 capabilities to the extension to inform vscode whether this extension would effect workspace features
This extension downloads files to the data directory used by vscode and does not use the /workspaces/ location for anything
Closes #21
Closes #22
This will not build until #54 is merged.