-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding editor for schema designer. #18689
base: main
Are you sure you want to change the base?
Conversation
2. Stopping unnecessary updates.
…esigner to use new API
…igner configuration styles
…osition calculations in SchemaDesigner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- localization/l10n/bundle.l10n.json: Language not supported
- localization/xliff/vscode-mssql.xlf: Language not supported
- package.json: Language not supported
- src/reactviews/pages/SchemaDesigner/schemaDesigner.css: Language not supported
Comments suppressed due to low confidence (2)
src/reactviews/pages/SchemaDesigner/schemaDesigner.tsx:180
- The function
calculateEditorPosition
should have tests to ensure it behaves correctly under different conditions.
function calculateEditorPosition(
src/reactviews/common/locConstants.ts:348
- [nitpick] The error message 'Foreign Key {0}' could be more descriptive. Consider changing it to 'Foreign Key Index: {0}'.
message: "Foreign Key {0}",
editedEntity: IEntity; | ||
editedOutgoingEdges: IRelationship[]; | ||
}> { | ||
throw new Error("Function not implemented."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The editEntity function is not implemented and will throw an error if called. Implement the function or ensure it is not called.
throw new Error("Function not implemented."); | |
// Basic implementation to avoid runtime errors | |
const editedEntity: IEntity = { | |
..._cell.value, | |
// Add any additional properties or modifications needed | |
}; | |
const editedOutgoingEdges: IRelationship[] = _outgoingEdges.map(edge => ({ | |
...edge.value, | |
// Add any additional properties or modifications needed | |
})); | |
return { | |
editedEntity, | |
editedOutgoingEdges, | |
}; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
PR Changes
|
…esigner contracts and logic
…eady notification in schema designer service
Editing Table:
Screen.Recording.2025-02-14.at.9.37.34.AM.mov
Updating Editor Position with graph changes (scroll and scale)
Screen.Recording.2025-02-14.at.9.39.12.AM.mov
Add new table
Screen.Recording.2025-02-14.at.9.43.35.AM.mov
Add and editing edge
Screen.Recording.2025-02-14.at.10.03.16.AM.mov
Undo / Redo
Screen.Recording.2025-02-14.at.10.05.42.AM.mov