Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding editor for schema designer. #18689

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Adding editor for schema designer. #18689

wants to merge 32 commits into from

Conversation

aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Feb 14, 2025

  1. Editing Table:

    Screen.Recording.2025-02-14.at.9.37.34.AM.mov
  2. Updating Editor Position with graph changes (scroll and scale)

    Screen.Recording.2025-02-14.at.9.39.12.AM.mov
  3. Add new table

    Screen.Recording.2025-02-14.at.9.43.35.AM.mov
  4. Add and editing edge

    Screen.Recording.2025-02-14.at.10.03.16.AM.mov
  5. Undo / Redo

    Screen.Recording.2025-02-14.at.10.05.42.AM.mov

@aasimkhan30 aasimkhan30 requested a review from Copilot February 14, 2025 17:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • localization/l10n/bundle.l10n.json: Language not supported
  • localization/xliff/vscode-mssql.xlf: Language not supported
  • package.json: Language not supported
  • src/reactviews/pages/SchemaDesigner/schemaDesigner.css: Language not supported
Comments suppressed due to low confidence (2)

src/reactviews/pages/SchemaDesigner/schemaDesigner.tsx:180

  • The function calculateEditorPosition should have tests to ensure it behaves correctly under different conditions.
function calculateEditorPosition(

src/reactviews/common/locConstants.ts:348

  • [nitpick] The error message 'Foreign Key {0}' could be more descriptive. Consider changing it to 'Foreign Key Index: {0}'.
message: "Foreign Key {0}",

editedEntity: IEntity;
editedOutgoingEdges: IRelationship[];
}> {
throw new Error("Function not implemented.");
Copy link
Preview

Copilot AI Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editEntity function is not implemented and will throw an error if called. Implement the function or ensure it is not called.

Suggested change
throw new Error("Function not implemented.");
// Basic implementation to avoid runtime errors
const editedEntity: IEntity = {
..._cell.value,
// Add any additional properties or modifications needed
};
const editedOutgoingEdges: IRelationship[] = _outgoingEdges.map(edge => ({
...edge.value,
// Add any additional properties or modifications needed
}));
return {
editedEntity,
editedOutgoingEdges,
};

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link

github-actions bot commented Feb 14, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.35% 50.70% $${\color{lightgreen} .35\% }$$
VSIX Size 12980 KB 12282 KB $${\color{lightgreen} -698 KB \space (-5\%) }$$
Webview Bundle Size 3188 KB 3200 KB $${\color{lightgreen} 12 KB \space (0\%) }$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant