Add missing tunnel module that is stopping VSIX activation #18712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-sanchez
requested review from
kburtram,
aasimkhan30,
cssuh,
caohai,
laurennat and
Benjin
as code owners
laurennat
approved these changes
Feb 19, 2025
|
Could you create an issue and link it here? especially if this is something for the feb release |
PR Changes
|
Updated PR description with the issue. |
|
Do you know if this is a regression? What we use this pkg for? I don't see we ever included this pkg before. @lewis-sanchez |
|
Ah I see, the usage of
|
Benjin
pushed a commit
that referenced
this pull request
Feb 20, 2025
kburtram
pushed a commit
that referenced
this pull request
Feb 20, 2025
) * Add missing tunnel module (#18712) (#18714) * Adding VS Code walkthroughs (#18694) (#18709) * adding walkthroughs * formatted * adding query sort/filter * loc update * updated pictures for Getting Started walkthrough * Adding images for Next Steps * loc * fixing json formatting * fixing merge * fixing whitespace * whitespace * reverting more whitespace * whitespace * nls whitespace * swapping for const * Fixing typo in package.json and adding missing string in nls.json * loc * Scaling screenshots down * fixing casing * xlf update * Added accessibility functionality for query plans (#18711) * added accesibility labels * localization --------- Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for this issue: #18713
This PR fixes the following issue that is preventing the VSCode for MSSQL extension from starting up.
I verified that the change resolves this error by installing the VSIX from the buddy build drop here: https://msdata.visualstudio.com/SQLToolsAndLibraries/_build/results?buildId=160997762&view=artifacts&pathAsName=false&type=publishedArtifacts
Extension host output for installing a VSIX with the fix from the buddy build artifact drop:
