Skip to content

Commit

Permalink
Fix cherry-pick issue
Browse files Browse the repository at this point in the history
  • Loading branch information
rchiodo committed Jan 28, 2019
1 parent 0186a66 commit 7ce203d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions news/3 Code Health/4156.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix build issue with code.tsx
2 changes: 1 addition & 1 deletion src/datascience-ui/history-react/code.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class Code extends React.Component<ICodeProps, ICodeState> {
this.state = {focused: false, cursorLeft: 0, cursorTop: 0, cursorBottom: 0, charUnderCursor: '', allowWatermark: true};
}

public componentDidUpdate = () => {
public componentDidUpdate = (prevProps: Readonly<ICodeProps>, prevState: Readonly<ICodeState>, snapshot?: {}) => {
// Force our new value. the RCM control doesn't do this correctly
if (this.codeMirror && this.props.readOnly && this.codeMirror.getValue() !== this.props.code) {
this.codeMirror.setValue(this.props.code);
Expand Down

0 comments on commit 7ce203d

Please sign in to comment.