dxgi: Add DXGI_OUTDUPL_FLAG enum annotation to DuplicateOutput1() #1981
Conversation
| @@ -13,11 +13,3 @@ _D3DCOLORVALUE | |||
| <IncludeRoot>/um/dxprogrammablecapture.h | |||
| --namespace | |||
| Windows.Win32.Graphics.Dxgi | |||
| --with-attribute | |||
There was a problem hiding this comment.
Inversely, could we also have all the =AssociatedEnum in here? It seems much nicer to me to have configuration in the namespace-specific settings.rsp than in one humongous global file, if possible?
There was a problem hiding this comment.
No. The scraper and the emitter have different roles and supporting toolchains.
There was a problem hiding this comment.
Is there any complete docs on what configures the scraper (probably the namespace-specific settings.rsp) and what configures the emitter (probably the glboal emitter.settings.rsp... 🙂), and when to use either?
There was a problem hiding this comment.
There was a problem hiding this comment.
@mikebattista unfortunately that doesn't explain directly which flags are available, nor what precedence I should stick to. Searching further in the repo shows that --enumMakeFlags is a feature of ClangSharpSourceToWinmd so it makes sense that that only works via emitter settings (and likewise, --with-attribute seems to be a feature of the scraper).
The question remains: do we prefer to set the Flags attribute on the emitter via --enumMakeFlags, or do we prefer to set it earlier via --with-attribute on the scraper as done before this PR?
On the side, alphabetically sort some flags and use `--enumMakeFlags` in `emitter.settings.rsp` instead of `--with-attribute XXX=Flags` in `Namespace/settings.rsp`.
MarijnS95
force-pushed
the
dxgi-associated-enum
branch
from
26da534
to
c4cc88f
Compare
Draft separation from #1911 (comment).
On the side, alphabetically sort some flags and use
--enumMakeFlagsinemitter.settings.rspinstead of--with-attribute XXX=FlagsinNamespace/settings.rsp.