DXC: Annotate new struct fields and enums #1989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `DXC_FOURCC` it would have been awesome if we could have something like the following, if `const` methods were supported: ```cs public static const uint DXC_FOURCC(char ch0, char ch1, char ch2, char ch3) => ch0 | (ch1 << 8) | (ch2 << 16) | (ch3 << 24); ```
MarijnS95
commented
Sep 3, 2024
Comment on lines
+28814
to
+28838
| { | ||
| "name": "DxcValidatorFlags", | ||
| "flags": true, | ||
| "autoPopulate": { | ||
| "filter": "DxcValidatorFlags_", | ||
| "header": "dxcapi.h" | ||
| }, | ||
| "uses": [ | ||
| { | ||
| "interface": "IDxcValidator", | ||
| "method": "Validate", | ||
| "parameter": "Flags" | ||
| }, | ||
| { | ||
| "interface": "IDxcValidator2", | ||
| "method": "ValidateWithDebug", | ||
| "parameter": "Flags" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "DxcVersionInfoFlags", | ||
| "flags": true, | ||
| "autoPopulate": { | ||
| "filter": "DxcVersionInfoFlags_", |
There was a problem hiding this comment.
Unfortunately both these static const UINT32s don't appear to be parsed by enums.json?
There was a problem hiding this comment.
Seems more like a ClangSharp limitation than enums.json.
There was a problem hiding this comment.
Yeah, either way it's something that I expected to show up, but it didn't. Should I manually declare "members", while leaving "autoPopulate" in place in hopes of getting a compilation conflict when ClangSharp can provide these to us, or is it a fix you can do elsewhere in the tooling?
As this PR shows we used to have manual fields for DXC_CP_ too (now unnecessary), while also relying on autoPopulate without conflicts being generated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #474 (comment)..
For
DXC_FOURCCit would have been awesome if we could have something like the following, ifconstmethods were supported: