Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrapeHeaders: Trim filenames when splitting for ; #1992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ScrapeHeaders: Trim filenames when splitting for ; #1992

wants to merge 1 commit into from

Conversation

MarijnS95
Copy link
Contributor

Fixes #1838

@MarijnS95
Copy link
Contributor Author

TODO: Need to check how many more things need this.

@mikebattista
Copy link
Contributor

TODO: Need to check how many more things need this.

Is this PR complete? Have you validated your original test case against your changes?

@MarijnS95
Copy link
Contributor Author

@mikebattista no, unfortunately I have not set up the repro case yet nor validated all the other .Split() calls that seem like they could benefit from the same change but am not sure about. Not to speak of the many remaining untouched .Split() calls. Guess I'm in a bit over my head.

@MarijnS95
Copy link
Contributor Author

In addition, I don't actually remember (if I ever did this at all) how to turn <Project Sdk="Microsoft.Windows.WinmdGenerator/0.59.13-preview"> into something that imports or replaces the "Sdk" with my own (local checkout of this) PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverar riverar riverar approved these changes

@mikebattista mikebattista Awaiting requested review from mikebattista mikebattista is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim whitespace when parsing <TraverseFiles> contents?
3 participants
@MarijnS95 @mikebattista @riverar