Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cross-compilation with stable gnullvm targets #3104

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jun 15, 2024

Continuation of #3007 but this time with a stable toolchain.

@mati865
Copy link
Contributor Author

mati865 commented Jun 15, 2024

It looks like a preinstalled stable toolchain was not yet updated to the latest version.

@kennykerr
Copy link
Collaborator

When do you expect that to be updated?

@mati865
Copy link
Contributor Author

mati865 commented Jun 17, 2024

Judging by the history of https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md, I'd expect it to happen today, but I don't have the details on how GitHub updates their images.

@riverar
Copy link
Collaborator

riverar commented Jun 17, 2024

Rather than wait for GitHub, which might be busy/frozen due to events this week, can we just update the tools at start of the workflow (like we already do)?

@mati865
Copy link
Contributor Author

mati865 commented Jun 17, 2024

If this fails again, I'll look into incorporating changes from other workflows to make sure Rust is up to date.

@kennykerr
Copy link
Collaborator

I don't know if this is related but GNU builds have started failing:

https://github.com/microsoft/windows-rs/actions/runs/9567088234/job/26373942886

@ChrisDenton
Copy link
Collaborator

It looks like a Windows Server 2022 update is currently in progress so it shouldn't be too long now.

@mati865
Copy link
Contributor Author

mati865 commented Jun 20, 2024

Even though GHA docs were updated yesterday so the compiler should be up-to-date now I added the step to update the toolchain like in the other jobs.

It looks like a Windows Server 2022 update is currently in progress so it shouldn't be too long now.

That's good, I guess?
Don't know how it's related, though.

I don't know if this is related but GNU builds have started failing:

microsoft/windows-rs/actions/runs/9567088234/job/26373942886

It uses GHA image 20240610.1.0 so it's unlikely to be related. Probably something in nightly or rustup. Maybe it's related to rust-lang/rust#125809?

@riverar
Copy link
Collaborator

riverar commented Jun 20, 2024

You can ignore the previous build error, we root caused that and fixed it here #3111 (comment)

@mati865
Copy link
Contributor Author

mati865 commented Jun 20, 2024

Ah, forgot about Mac.

Added if: startsWith(matrix.image, 'ubuntu-') && contains(matrix.target, 'gnullvm') || endsWith(matrix.target, 'gnu') to Test step so the tests for gnullvm won't run there, but it's still not ideal since there are 3 macos gnullvm jobs that basically do checkout exit with success.
Still, it's an improvement compared to the master branch, so good to go?

@mati865 mati865 marked this pull request as ready for review June 20, 2024 17:22
@kennykerr
Copy link
Collaborator

Hmm, just noticed those unused mac tests. We can clean those up separately.

@kennykerr kennykerr merged commit 2ec4e06 into microsoft:master Jun 20, 2024
81 checks passed
@mati865 mati865 deleted the patch-1 branch June 20, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants