Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated todo.md #9395

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Updated todo.md #9395

merged 2 commits into from
Jul 23, 2024

Conversation

GuidoZam
Copy link
Contributor

The documentation explains that, among the other properties for the ToDo control, there is the hideOptions property but it doesn't seems to be used anywhere in the code and also, to support my assumption, if it's set to true nothing changes in the UI. That said I've updated the documentation to remove the property from the available properties of the ToDo control.


Note

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Copy link

Learn Build status updates of commit 5ff3427:

✅ Validation status: passed

File Status Preview URL Details
concepts/toolkit/components/todo.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@sebastienlevert
Copy link
Collaborator

Thanks for the PR!

While this seems like it's not used, I asked @Mnickii and @musale to ensure we are not using this elsewhere. It's I heriting from MgtTaskBase that has this property... So we need to make sure it's the right spot for the property and if it's useful in those context.

Well come back to you shortly, thanks!

@Mnickii
Copy link
Contributor

Mnickii commented Jul 19, 2024

hideOptions is inherited from MgtTaskBase but not currently in use anywhere on mgt-todo, neither is hideHeader. These two should be removed, I don't believe there's a future context in the works in which they could be useful. hideOptions is also available on mgt-planner, which is it's own component and it's used to set whether the task options are rendered.

@sebastienlevert
Copy link
Collaborator

@GuidoZam can you also remove the hideHeader from the docs on mgt-todo. Thanks!

Removed hideHeader attribute from table
@GuidoZam
Copy link
Contributor Author

@sebastienlevert done 😊

Copy link

Learn Build status updates of commit 85bef76:

✅ Validation status: passed

File Status Preview URL Details
concepts/toolkit/components/todo.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@sebastienlevert sebastienlevert self-requested a review July 19, 2024 19:55
Copy link
Collaborator

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@Lauragra Lauragra added the review requested Use for external PRs that need to be reviewed by content author. label Jul 19, 2024
@sebastienlevert sebastienlevert added the ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. label Jul 22, 2024
@Lauragra Lauragra merged commit 1f19982 into microsoftgraph:main Jul 23, 2024
7 checks passed
@GuidoZam GuidoZam deleted the guidozam-patch-docs branch July 23, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. review requested Use for external PRs that need to be reviewed by content author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants