Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of managing attribute mappings #9418

Closed
wants to merge 10 commits into from

Conversation

ArvindHarinder1
Copy link
Contributor

Instructions: Add any supporting information, such as a description of the PR changes, here.


Note

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Copy link

Learn Build status updates of commit 6361632:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/api/synchronization-synchronizationschema-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 6467720:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/api/synchronization-synchronizationschema-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ArvindHarinder1
Copy link
Contributor Author

#sign-off

@microsoft-github-policy-service microsoft-github-policy-service bot added the ready for content review PR is ready for a content review - content development and tech review are complete. label Sep 18, 2024
@Lauragra
Copy link
Contributor

@ArvindHarinder1 , this is the public mirror of the docs for external contributions. Can you please open this PR in the microsoft-graph-docs authoring repo, so we can follow our content workflow? Thanks.

@FaithOmbongi FaithOmbongi self-assigned this Sep 19, 2024
@FaithOmbongi FaithOmbongi added the area: Entra APIs and issues relating to Microsoft Entra (previously Azure AD) features. label Sep 19, 2024
Copy link
Collaborator

@FaithOmbongi FaithOmbongi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArvindHarinder1 - Please move these changes to the private repo = https://github.com/microsoftgraph/microsoft-graph-docs, then close this PR. Some key validations and the preview feature aren't available in this public mirror and therefore errors in your file aren't getting caught at this stage.

Apply the same review suggestions to the branch you open in the private repo.

Comment on lines +187 to +191
# [JavaScript](#tab/javascript)
[!INCLUDE [sample-code](../includes/snippets/javascript/update-synchronizationschema-javascript-snippets.md)]
[!INCLUDE [sdk-documentation](../includes/snippets/snippets-sdk-documentation-link.md)]

---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this - it'll be added by the snippets generator

@@ -42,7 +42,7 @@ In the request body, supply the [synchronizationSchema](../resources/synchroniza

If successful, returns a `204 No Content` response code. It doesn't return anything in the response body.

## Example
## Example 1

##### Request
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce this header and the "Response" to H4

},
"targetAttributeName":"timezone"
}
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray comma

@FaithOmbongi FaithOmbongi added blocked PRs that are blocked from content review or getting merged for some reason. content review in progress and removed ready for content review PR is ready for a content review - content development and tech review are complete. labels Sep 19, 2024
ArvindHarinder1 and others added 8 commits September 19, 2024 12:59
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
…pdate.md

Co-authored-by: Faith Moraa Ombongi <ombongi.moraa.fe@gmail.com>
Copy link

Learn Build status updates of commit 0807b95:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/api/synchronization-synchronizationschema-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 980836c:

⚠️ Validation status: warnings

File Status Preview URL Details
api-reference/v1.0/api/synchronization-synchronizationschema-update.md ⚠️Warning Details

api-reference/v1.0/api/synchronization-synchronizationschema-update.md

  • Line 188, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Entra APIs and issues relating to Microsoft Entra (previously Azure AD) features. area: identity awaiting internal response blocked PRs that are blocked from content review or getting merged for some reason. content review in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants