Skip to content

USC-SIkJalpha Disparity Round 1 Submission #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

maa989
Copy link
Contributor

@maa989 maa989 commented Jul 11, 2024

No description provided.

Copy link

Run validation on files: 2024-06-25-USC-SIkJalpha.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, latino, inc inf
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, latino, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, asian, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 06, other, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, latino, inc case
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 06, other, inc case

Target Columns:

No errors or warnings found in target and associated columns

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

❌ Error 1001: The race_ethnicity column contains unexpected value: 'latino'. 'race_ethnicity' can only be: asian, black, white, other, overall.

Copy link

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

Copy link

Run validation on files: 2024-06-25-USC-SIkJalpha.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, asian, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 06, other, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 06, other, inc case

Target Columns:

No errors or warnings found in target and associated columns

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

Copy link

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@LucieContamin
Copy link
Contributor

LucieContamin commented Jul 11, 2024

Hi @maa989

Thank you for your submission, I just wanted to verify that I understand correctly the sample ID numbering: there is no stochasticity, every models runs has a different run_grouping "grouped" by race_ethnicity, location, horizon, and, target. Is that correct?

Also, would it be possible to remove the sub-folder in the model-metadata folder. The yaml file should be stored directly in the model-metadata folder.

Please let me know if any issues or questions,

Best, Lucie

@maa989
Copy link
Contributor Author

maa989 commented Jul 11, 2024

Hi @LucieContamin, yes that is correct there is no stochasticity. I have also removed the sub-folder in the model-metadata folder. Let me know if there are any other concerns or questions.

Best,
Majd

@LucieContamin
Copy link
Contributor

Thanks for the metadata update and apologies for the multiple message, but looking at the PDF results in the validation action, it seems that your death projection are on the same scale as the infection, with for example a median peak close to 600000 for the overall population in CA. Is that expected?

Copy link

Run validation on files: 2024-06-25-USC-SIkJalpha.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, asian, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 06, other, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 06, other, inc case

Target Columns:

No errors or warnings found in target and associated columns

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

Copy link

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission is available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@maa989
Copy link
Contributor Author

maa989 commented Jul 11, 2024

Thanks for noticing! there was a small bug when converting the results. This should be fixed now

@LucieContamin
Copy link
Contributor

thanks for the quick update, it looks all good now!

@LucieContamin LucieContamin merged commit 2dc2a22 into midas-network:main Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants