Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIH UIUC RIFTcov resubmission #12

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

SophieLLarsen
Copy link
Contributor

@SophieLLarsen SophieLLarsen commented Jul 12, 2024

Description

Updating the latin hypercube sampling to include uncertainty in the change in NPI compliance between calibration and projection. Includes new model output and updated metadata, abstract.

Checklist

  • [ X] Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

Run validation on files: 2024-06-25-NIH_UIUC-RIFTcov.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@SophieLLarsen
Copy link
Contributor Author

@LucieContamin Just resubmitted to incorporate further sources of uncertainty during the projection period. Let me know if any questions!

@LucieContamin
Copy link
Contributor

Hi @BarnabyLlama , thank you for the update. I all looks good to me, just for information I cannot merge the PR while it's a draft. Once you are ready, please feel free to change it to "ready for review" or I am also happy to do it if you prefer (just let me know when) and merge it.

Please let me know if any issues or questions,
Best,
Lucie

@SophieLLarsen SophieLLarsen marked this pull request as ready for review July 12, 2024 14:37
@SophieLLarsen
Copy link
Contributor Author

Hi @LucieContamin, sorry! Thought I had marked it for review already. Now done.

Best,
Sophie

@LucieContamin LucieContamin merged commit 9262349 into midas-network:main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants