Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIH-UIUC RIFTcov Phase 2 #18

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

SophieLLarsen
Copy link
Contributor

@SophieLLarsen SophieLLarsen commented Aug 8, 2024

Description

Uploading simulations for Phase 2.

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

github-actions bot commented Aug 8, 2024

Run validation on files: 2024-07-16-NIH_UIUC-RIFTcov.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

❌ Error 202: At least 1 of the 'scenario_id' do(es) not correspond: 'A-2020-05-01, B-2020-05-01, C-2020-05-01, D-2020-05-01'. The scenarios ids for this round are: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. Please verify.
❌ Error 204: At least 1 of the required 'scenario_id' is missing: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. The scenarios ids for the target(s): inc case (sample) and for this round are: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. Please verify.
❌ Error 204: At least 1 of the required 'scenario_id' is missing: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. The scenarios ids for the target(s): inc death (sample) and for this round are: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. Please verify.
❌ Error 204: At least 1 of the required 'scenario_id' is missing: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. The scenarios ids for the target(s): inc inf (sample) and for this round are: 'A-2020-11-15, B-2020-11-15, C-2020-11-15, D-2020-11-15'. Please verify.

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

❌ Error 904: Samples are expected in the submission for the target(s): inc death, inc inf. please verify.

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

Copy link

github-actions bot commented Aug 8, 2024

Run validation on files: 2024-07-16-NIH_UIUC-RIFTcov.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

1 similar comment
Copy link

github-actions bot commented Aug 8, 2024

Run validation on files: 2024-07-16-NIH_UIUC-RIFTcov.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@SophieLLarsen SophieLLarsen marked this pull request as ready for review August 8, 2024 13:38
@LucieContamin
Copy link
Contributor

Hi @BarnabyLlama ,

Thank you for the submission, I just to verify that I understand correctly the sample ID numbering: there is no stochasticity (as we discuss previously), every models runs has a different run_grouping "grouped" by race_ethnicity, scenario_id, horizon, and, target. Is that correct? (Meaning every run_grouping should match a single run that included all values for race_ethnicity, horizon, scenario and target)

Please let me know if any issues or questions,
Best,
Lucie

@SophieLLarsen
Copy link
Contributor Author

Hi @LucieContamin, that is correct!

Sophie

@LucieContamin LucieContamin merged commit b626b42 into midas-network:main Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants